Yes, a single load(boolean textFormat) is best. If some other code
somewhere depends on this, I think it won't be a problem for them to
upgrade.


On Mon, Jan 13, 2014 at 3:46 PM, Benjy Weinberger
<notifications@github.com>wrote:

> In src/com/sun/tools/jmake/Main.java:
>
> > @@ -324,13 +329,18 @@ public void mainProgrammatic(String args[]) throws
> >              }
> >
> >              Utils.startTiming(Utils.TIMING_PDBREAD);
> > -            PCDContainer pcdc = PCDContainer.load(pdbFileName);
> > +            PCDContainer pcdc;
> > +            if (pdbTextFormat) {
> > +                pcdc = PCDContainer.loadFromText(pdbFileName);
> > +            } else {
> > +                pcdc = PCDContainer.load(pdbFileName);
>
> Didn't want to change the existing API, in case anything external relies
> on it. But if you think it's OK, I'm fine with that. Or even better, just
> using a single load method with a boolean argument.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/pantsbuild/jmake/pull/2/files#r8845850>
> .
>