Move ChangeVersionWrapper destructor out of line.

With clang/win, the vtable of ChangeVersionWrapper ends up being referenced
for some reason, which causes the destructor to be defined, which requires
a definition of SQLErrorData. So move the destructor out of line, where
the definition is available.

BUG=413478
R=michaeln@chromium.org, rnk@chromium.org

Review URL: https://codereview.chromium.org/572343002

git-svn-id: svn://svn.chromium.org/blink/trunk@182093 bbb929c8-8fbe-4397-9dbb-9b2b20218538
Remove TargetedStyleRecalc runtime flag.

The flag has had status=stable for more than 4 months.

R=chrishtr@chromium.org,esprehn@chromium.org,abarth@chromium.org

Review URL: https://codereview.chromium.org/562403002

git-svn-id: svn://svn.chromium.org/blink/trunk@182098 bbb929c8-8fbe-4397-9dbb-9b2b20218538
Auto-rebaseline for r182085

http://src.chromium.org/viewvc/blink?view=revision&revision=182085

TBR=jchaffraix@chromium.org

Review URL: https://codereview.chromium.org/580573002

git-svn-id: svn://svn.chromium.org/blink/trunk@182099 bbb929c8-8fbe-4397-9dbb-9b2b20218538
Add saveImageFromDataURL() and use it in saveImageAt().

The new method is invoked as a response of saveImageAt() and takes over a data
url string as a parameter. Then we use the string of data url instead of real
url to avoid size-limits for url on IPC subsystems. Ultimately, this new code
path imposes a higher limit for data url used for saving canvases and large
images to disk.

This change is used by the following chromium side CL.
  https://crrev.com/518693002/

BUG=69227,401888

Review URL: https://codereview.chromium.org/518043003

git-svn-id: svn://svn.chromium.org/blink/trunk@182100 bbb929c8-8fbe-4397-9dbb-9b2b20218538
Remove WEB_ANIMATION_SUPPORTS_FULL_DIRECTION define

This is the 4th and last part of accelerated direction control.

Now that legacy path in compositor has been removed, the
WEB_ANIMATION_SUPPORTS_FULL_DIRECTION define becomes unneeded.

It builds on top of https://codereview.chromium.org/227733004,
https://codereview.chromium.org/225183014 and
https://codereview.chromium.org/576553002/

BUG=348071

Review URL: https://codereview.chromium.org/572363002

git-svn-id: svn://svn.chromium.org/blink/trunk@182101 bbb929c8-8fbe-4397-9dbb-9b2b20218538
Fix point conversions in PopupContainer.

This broke when it stopped inheriting ScrollView.

BUG=414598

Review URL: https://codereview.chromium.org/572943003

git-svn-id: svn://svn.chromium.org/blink/trunk@182102 bbb929c8-8fbe-4397-9dbb-9b2b20218538
Auto-rebaseline for r182077

http://src.chromium.org/viewvc/blink?view=revision&revision=182077

BUG=390125
TBR=aberent@chromium.org

Review URL: https://codereview.chromium.org/561273005

git-svn-id: svn://svn.chromium.org/blink/trunk@182103 bbb929c8-8fbe-4397-9dbb-9b2b20218538
Oilpan: fix build after r182077.

TBR=oilpan-reviews
BUG=390125
NOTRY=true

Review URL: https://codereview.chromium.org/572933005

git-svn-id: svn://svn.chromium.org/blink/trunk@182104 bbb929c8-8fbe-4397-9dbb-9b2b20218538
Update PixelRef GenerationID when copying data from WebGL to its pixels

This patch is preventing an upcoming Skia change to break the following test:
fast/canvas/webgl/canvas-test.html

Because the GenerationID of the GrPixelRef was not updated, it was causing a false cache hit in SkBitmapCache and thus, was making readPixels return the wrong data.

BUG=413900

Review URL: https://codereview.chromium.org/570703002

git-svn-id: svn://svn.chromium.org/blink/trunk@182105 bbb929c8-8fbe-4397-9dbb-9b2b20218538
Add null-checks before dereferencing.

We got a number of crash reports with null frameView in contentsSize().
The surrounding code also suggests that these checks might be necessary.

BUG=

Review URL: https://codereview.chromium.org/538013002

git-svn-id: svn://svn.chromium.org/blink/trunk@182106 bbb929c8-8fbe-4397-9dbb-9b2b20218538
Mark media/audio-concurrent-supported.html as flaky.

Looks like the test became flaky in r182039.

TBR=scherkus@chromium.org
BUG=414649

Review URL: https://codereview.chromium.org/567333003

git-svn-id: svn://svn.chromium.org/blink/trunk@182108 bbb929c8-8fbe-4397-9dbb-9b2b20218538
Merge FontPlatformDataHarfBuzz into FontPlatformData

From WebKit legacy we have two redundant copies of this file.
In order for switching shapers on mac, we need to fuse these files again.
This is part two of the merge,
after the headers were merged in r181655 / ad011a9df.

This is a re-land after the original patch got reverted
in 9ebff84df32cb645b6 due to uninitialized memory, reported in bug 413229.
Now changed: Initialized m_widthVariant in SkTypeface FontPlatformData constructor,
reshuffle windows initializers in the right order, and
added m_isHashTableDeletedValue to the Skia hash function.

BUG=334269,413229
R=eae

Review URL: https://codereview.chromium.org/568393003

git-svn-id: svn://svn.chromium.org/blink/trunk@182111 bbb929c8-8fbe-4397-9dbb-9b2b20218538
Fixing broken graphics layer culling with 2D canvas

Currently, in cases where a canvas element's background cannot
be direct-composited, opaque backgrounds fail to render. This
is because the compositor thinks the canvas layer is opaque when
it is actually its container that is opaque. The opacity logic
was updated to correctly determine whether a canvas layer is
opaque.

BUG=412718
TEST=layout tests under compositing/draws-content + fast/canvas/bug412718.html

Review URL: https://codereview.chromium.org/569843002

git-svn-id: svn://svn.chromium.org/blink/trunk@182113 bbb929c8-8fbe-4397-9dbb-9b2b20218538
Add a renderName to RenderTextFragment.

Currently any RenderTextFragment will show as RenderText in the dump'd tree.
This makes things confusing when debugging as you don't know which object
you're dealing with.

This CL adds a renderName() method to RenderTextFragment to make this more
clear.

Review URL: https://codereview.chromium.org/575833002

git-svn-id: svn://svn.chromium.org/blink/trunk@182114 bbb929c8-8fbe-4397-9dbb-9b2b20218538
Remove an unnecessary layout when a positioned element's margin changes

Postioned objects' margins don't collapse so do not depend on the
collapsing code in their parents to position them properly. Remove this
unnecessary layout on the parent.

BUG=332860

Review URL: https://codereview.chromium.org/571803002

git-svn-id: svn://svn.chromium.org/blink/trunk@182116 bbb929c8-8fbe-4397-9dbb-9b2b20218538
Fix some android gn configuration

Fix file missing due to sources_assignment_filter.

Fix some use_openmax config (Depends on http://crrev.com/568363002).

BUG=359249
TBR=eseidel

Review URL: https://codereview.chromium.org/561173006

git-svn-id: svn://svn.chromium.org/blink/trunk@182119 bbb929c8-8fbe-4397-9dbb-9b2b20218538
Fix media layout tests that made invalid assumptions about timeupdate.

Blink r182039 removed unnecessary checks against firing timeupdate
events in response to ece894570c5f32f7f404f4c8da9ff8b9f03b75cd, which
made it possible for the currentTime value to remain the same for
brief periods of time.

The media controller tests were accidentally relying on the timeupdate
event that gets automatically fired when MediaController issues a seek.
Instead, we should wait for that seek to complete before issuing play()
and waiting for the timeupdate event that follows.

The audio-concurrent-supported.html test picked a magic number of
timeupdate events (two, to be exact) before inspecting whether
currentTime increased past zero. Again, because we now fire non-periodic
timeupdate events reliably, this test is picking up on the wrong events
to make it's judgement on what currentTime should be.

BUG=414649

Review URL: https://codereview.chromium.org/574883002

git-svn-id: svn://svn.chromium.org/blink/trunk@182122 bbb929c8-8fbe-4397-9dbb-9b2b20218538
Revert of Move ChangeVersionWrapper destructor out of line. (patchset #1 id:1 of https://codereview.chromium.org/572343002/)

Reason for revert:
No longer needed, we fixed this in clang instead (see BUG=).

Original issue's description:
> Move ChangeVersionWrapper destructor out of line.
> 
> With clang/win, the vtable of ChangeVersionWrapper ends up being referenced
> for some reason, which causes the destructor to be defined, which requires
> a definition of SQLErrorData. So move the destructor out of line, where
> the definition is available.
> 
> BUG=413478
> R=michaeln@chromium.org, rnk@chromium.org
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182093

TBR=rnk@chromium.org,michaeln@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=413478

Review URL: https://codereview.chromium.org/563143005

git-svn-id: svn://svn.chromium.org/blink/trunk@182124 bbb929c8-8fbe-4397-9dbb-9b2b20218538
Fix Retina and Mavericks NeedsRebaselines entries after r182114.

TBR=dsinclair@chromium.org

Review URL: https://codereview.chromium.org/543963004

git-svn-id: svn://svn.chromium.org/blink/trunk@182125 bbb929c8-8fbe-4397-9dbb-9b2b20218538
Revert of Revert of Temporarily let DocumentMakerController use invalidatePaintForWholeRenderer (patchset #2 id:70001 of https://codereview.chromium.org/574773002/)

Reason for revert:
The RenderText change needs to be reverted because it causes failure of some chromium browsertest. 

Original issue's description:
> Revert of Temporarily let DocumentMakerController use invalidatePaintForWholeRenderer (patchset #3 id:60001 of https://codereview.chromium.org/499493003/)
> 
> Reason for revert:
> We have fixed the RenderText invalidation issue (crbug.com/394133).
> 
> Original issue's description:
> > Temporarily let DocumentMakerController use invalidatePaintForWholeRenderer
> > 
> > setShouldDoFullPaintInvalidation doesn't work for RenderText yet.
> > 
> > BUG=405501
> > 
> > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180877
> 
> TBR=jchaffraix@chromium.org,esprehn@chromium.org,leviw@chromium.org
> BUG=405501
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182089

TBR=jchaffraix@chromium.org,esprehn@chromium.org,leviw@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=405501

Review URL: https://codereview.chromium.org/574913002

git-svn-id: svn://svn.chromium.org/blink/trunk@182126 bbb929c8-8fbe-4397-9dbb-9b2b20218538