Aden 1591 add leaderboard

Cool, thank you!

On 12/09/2014 08:29 PM, Sergey Naumov wrote:
> In extensions/wikia/AdEngine/js/AdSlotsVenus.js
> <https://github.com/Wikia/app/pull/5653#discussion-diff-21555028>:
>
>> +		var i,
>> +			len,
>> +			remainingSlots,
>> +			slotName,
>> +			slotHtml,
>> +			$slot,
>> +
>> +			originalContentWidth;
>> +
>> +		remainingSlots = inContentLeaderboards.slice();
>> +
>> +		originalContentWidth = container.clientWidth;
>> +
>> +		for (i = 0, len = headers.length; i < len && slotsAdded < maxSlots; i += 1) {
>> +
>> +			if (isValidOffset(headers[i].offsetTop) && headers[i].clientWidth + 20 >= originalContentWidth) {
>
> Yes I will do refactoring tomorrow
> … <#>
> On Dec 9, 2014 7:10 PM, "Piotr Gabryjeluk" <notifications@github.com>
> wrote: In extensions/wikia/AdEngine/js/AdSlotsVenus.js
> <https://github.com/Wikia/app/pull/5653#discussion-diff-21547738>: > +
> var i, > + len, > + remainingSlots, > + slotName, > + slotHtml, > +
> $slot, > + > + originalContentWidth; > + > + remainingSlots =
> inContentLeaderboards.slice(); > + > + originalContentWidth =
> container.clientWidth; > + > + for (i = 0, len = headers.length; i < len
> && slotsAdded < maxSlots; i += 1) { > + > + if
> (isValidOffset(headers[i].offsetTop) && headers[i].clientWidth + 20 >=
> originalContentWidth) { can we make it use jQuery for the width
> calculations to avoid the + 20? — Reply to this email directly or view
> it on GitHub <https://github.com/Wikia/app/pull/5653/files#r21547738>.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Wikia/app/pull/5653/files#r21555028>.
>