test cases added for controller