is this ready to be merged now ?
 
Date: Thu, 8 May 2014 07:21:11 -0700
From: notifications@github.com
To: pfsense-packages@noreply.github.com
CC: martin@fuchs-kiel.de
Subject: Re: [pfsense-packages] correct autodiscover settings (wrong hostname) and bump pkg-version (#656)

In config/squid3/31/squid_reverse.inc:

>  			}
>  		if (is_array($owa_dirs))
>  		  foreach ($owa_dirs as $owa_dir)
>  			$conf .= "acl OWA_URI_pfs url_regex -i ^https://{$settings['reverse_external_fqdn']}/$owa_dir.*$\n";
> -		}	
> +			
> +		if (($settings['reverse_owa'] == 'on') && (!empty($settings['reverse_owa_ip'])) && ($settings['reverse_owa_autodiscover'] == 'on')) {
> +			$reverse_external_domain = strstr($settings['reverse_external_fqdn'], '.');
> +			$conf .= "acl OWA_URI_pfs url_regex -i ^https://autodiscover$reverse_external_domain/AutoDiscover/AutoDiscover.xml\n";

Please protect variable name with {} when you are inside a string


—
Reply to this email directly or view it on GitHub.