Add request state updating functionality to API

WIP

Adds a new `update_state` method to the API that uses the existing API key mechanism to send a status update to a request created via an external API request. Intended usage - foi-register end-users confirming whether the information they requested has been disclosed ([the parallel work on foi-register can be found here](https://github.com/mysociety/foi-register/tree/issues/169-ask-user-to-confirm-request-state)). Status description mismatches should be handled on the foi-register side but unexpected status values are rejected with a 500 error by the API.

Adds an optional parameter to the pre-existing `add_correspondence` API method to allow it to update status (intended use - updates from a public body) if a `state` value is supplied. Again, the foi-register code is responsible for handling state description mismatches but in this case the API deals with erroneous data by ignoring that part of the request.

Apologies for having restructured `api_controller_spec` but I kept losing track of which API methods the various tests were targeting. I will be happy to change it back before finalising the Pull Request if I've caused trouble.
This message was created automatically by mail delivery software.

A message that you sent could not be delivered to one or more of its
recipients. This is a temporary error. The following address(es) deferred:

  skenaja@gmail.com
    Domain alexskene.com has exceeded the max emails per hour (410/400 (102%)) allowed.  Message will be reattempted later

------- This is a copy of the message, including all the headers. ------
Received: from github-smtp2-ext6.iad.github.net ([192.30.252.197]:37238 helo=github-smtp2b-ext-cp1-prd.iad.github.net)
	by zurich.footholds.net with esmtps (UNKNOWN:DHE-RSA-AES256-GCM-SHA384:256)
	(Exim 4.82)
	(envelope-from <noreply@github.com>)
	id 1WzpXs-0008Tj-1h
	for alex@alexskene.com; Wed, 25 Jun 2014 16:55:36 +0100
Date: Wed, 25 Jun 2014 08:55:27 -0700
From: Hound <notifications@github.com>
Reply-To: mysociety/alaveteli <reply@reply.github.com>
To: mysociety/alaveteli <alaveteli@noreply.github.com>
Message-ID: <mysociety/alaveteli/pull/1631/r14195053@github.com>
In-Reply-To: <mysociety/alaveteli/pull/1631@github.com>
References: <mysociety/alaveteli/pull/1631@github.com>
Subject: Re: [alaveteli] Add request state updating functionality to API
 (#1631)
Mime-Version: 1.0
Content-Type: multipart/alternative;
 boundary="--==_mimepart_53aaf0efc50bc_634d3fe74fbd92c014283b";
 charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Recipient: skenaja
List-ID: mysociety/alaveteli <alaveteli.mysociety.github.com>
List-Archive: https://github.com/mysociety/alaveteli
List-Post: <mailto:reply@reply.github.com>
List-Unsubscribe: <mailto:unsub+p-14195053-b55608bef82b6235e591e3677f9414519b1f8923-510285@reply.github.com>,
 <https://github.com/notifications/unsubscribe/510285__eyJzY29wZSI6Ik5ld3NpZXM6TXV0ZSIsImV4cGlyZXMiOjE3MTkzMzA5MjcsImRhdGEiOnsiaWQiOjM1MzExOTc0fX0=--b86e78ac55576816689e7cfb289c30aba60e4704>
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: alex@alexskene.com


----==_mimepart_53aaf0efc50bc_634d3fe74fbd92c014283b
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

> -    end
> +    # GET /api/v2/body/:id/request_events.:feed_type
> +    describe 'showing public body info' do
> +        it 'should show an Atom feed of new request events' do
> +            get :body_request_events,
> +                :id => public_bodies(:geraldine_public_body).id,
> +                :k => public_bodies(:geraldine_public_body).api_key,
> +                :feed_type => 'atom'
> +
> +            response.should be_success
> +            response.should render_template("api/request_events")
> +            assigns[:events].size.should > 0
> +            assigns[:events].each do |event|
> +                event.info_request.public_body.should == public_bodies(:geraldine_public_body)
> +                event.outgoing_message.should_not be_nil
> +                event.event_type.should satisfy { |x| ['sent', 'followup_sent', 'resent', 'followup_resent'].include?(x) }

Line is too long. [122/80]

---
Reply to this email directly or view it on GitHub:
https://github.com/mysociety/alaveteli/pull/1631/files#r14195053
----==_mimepart_53aaf0efc50bc_634d3fe74fbd92c014283b
Content-Type: text/html;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

<p>In spec/controllers/api_controller_spec.rb:</p>
<pre style='color:#555'>&gt; -    end
&gt; +    # GET /api/v2/body/:id/request_events.:feed_type
&gt; +    describe &#39;showing public body info&#39; do
&gt; +        it &#39;should show an Atom feed of new request events&#39; do
&gt; +            get :body_request_events,
&gt; +                :id =&gt; public_bodies(:geraldine_public_body).id,
&gt; +                :k =&gt; public_bodies(:geraldine_public_body).api_key,
&gt; +                :feed_type =&gt; &#39;atom&#39;
&gt; +
&gt; +            response.should be_success
&gt; +            response.should render_template(&quot;api/request_events&quot;)
&gt; +            assigns[:events].size.should &gt; 0
&gt; +            assigns[:events].each do |event|
&gt; +                event.info_request.public_body.should == public_bodies(:geraldine_public_body)
&gt; +                event.outgoing_message.should_not be_nil
&gt; +                event.event_type.should satisfy { |x| [&#39;sent&#39;, &#39;followup_sent&#39;, &#39;resent&#39;, &#39;followup_resent&#39;].include?(x) }
</pre>
<p>Line is too long. [122/80]</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br>Reply to this email directly or <a href="https://github.com/mysociety/alaveteli/pull/1631/files#r14195053">view it on GitHub</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/510285__eyJzY29wZSI6Ik5ld3NpZXM6QmVhY29uIiwiZXhwaXJlcyI6MTcxOTMzMDkyNywiZGF0YSI6eyJpZCI6MzUzMTE5NzR9fQ==--f84597d265d4889123fb2a3ecce125a31003e32c.gif" width="1" /></p>
----==_mimepart_53aaf0efc50bc_634d3fe74fbd92c014283b--