Adding PhotoSphere demo.  Needs to be refactored to use Resources and CM...

...ake rules for the external EXIV2.exe parser.
"Why does she even have that lever, anyway?"

On Tue, Oct 21, 2014 at 7:36 PM, Alex Benton <alex@bentonian.com> wrote:

> Swapped.
> You can't default the pixels to null, there would be no data.
>
> On Tue, Oct 21, 2014 at 7:34 PM, Brad Davis <notifications@github.com>
> wrote:
>
>> In examples/cpp/common/GlUtils.h:
>>
>> > @@ -126,6 +127,19 @@ class GlUtils {
>> >      getImageAsTexture(texture, resource, imageSize, target);
>> >    }
>> >
>> > +  /**
>> > +  * A convenience method for loading unsigned char (RGB) pixels into textures.
>> > +  */
>> > +  static gl::TexturePtr getImageAsTexture(unsigned char *pixels, glm::uvec2 dimensions) {
>>
>> Please swap the order of the parameters, and default the pixels to null.
>> Also make dimensions a const reference.
>>
>> —
>> Reply to this email directly or view it on GitHub
>> <https://github.com/OculusRiftInAction/OculusRiftInAction/pull/36/files#r19168827>
>> .
>>
>
>