correct the bugs reference url in man documents

All the bugs reference in nova man documents are incorrect.
Nova bugs are managed at launchpad, not the nova.openstack.org

Change-Id: Id5bbf09ad8ba079d4de959314123437031ded3ab
Fix incorrect kwargs 'reason' for HTTPBadRequest

webob.exc.HTTPBadRequest doesn't have attribute 'reason', and its
__init__ method doesn't have such parameter too, so if we use such
kwargs, it will not be accepted by constructor of base class
WSGIHTTPException, then the http response body will format message
using default explanation instead of what we expected.

We should use kwargs 'explanation' instead of wrong 'reason'.

Change-Id: I02619164176a723e313ae274e527948d45fa6cad
Closes-Bug: #1264223
compute: format_message is a method not an attribute

The method format_message used to convert an exception to a string
it uses as an attribute. This patch fix the problem.

Change-Id: Ia1af1644f64d9d12edc905d2ec613aef1927e644
Replaces exception re-raising in Hyper-V

In a few cases in the Hyper-V driver classes, generic exceptions
are getting caught, logged and a domain specific exception is raised.

This creates issues in identifying the exception cause programmatically
(e.g. in unit tests).

This patch enforces the usage of excutils.save_and_reraise_exception()

Closes-Bug: #1280363

Change-Id: I27cc54941c5f592ea567ccaa8fa369362da1427f
Unmount the NFS and GlusterFS shares on detach

When attaching an NFS or GlusterFS volume, nova mounts the share so it
can be reused by other instances but it is not unmounted when detaching.

This patch adds the disconnect_volume method to both drivers, which will
try to unmount the share. If a volume in that share is still being used
by another instance, the umount command will fail with the error 'target
is busy' and we will ignore it. Any other error while unmounting will be
properly logged. In any case the detach will fail because nova hasn't
been able to unmount the share.

Closes-Bug: #1285209
Change-Id: I79289524541a88ad359b3465719055cd402b4e3d
VMware Driver update correct disk usage stat

The nodes managed by VMware VCDriver driver can have multiple
datastores (disk abstraction) attached to it. The driver currently
reports the disk usage of a datastore that has the largest capacity.
But it doesn't report a consolidated disk usage. As a result, the
node's storage capability is under-reported in many occassions.

This patch fixes this issue by aggregating the disk freespace,
capacity from all attached datastores.

Closes-Bug: #1220459

Change-Id: I818a041f33a045773fc799de2c69628064ef8cbf
Skip sqlite-specific tests if sqlite is not configured

There are several tests in test_migration_utils which only work if
sqlite is configured for migration tests, but two of them are missing
the conditional checks for skipping the test.

Also renames test_check_shadow_table_with_unsupported_type to
test_check_shadow_table_with_unsupported_sqlite_type since it's specific
to sqlite.

Closes-Bug: #1275352

Change-Id: I46f1b95e654bc702c76790350a8929d03c04e0a1
Remove extra space at the end of help string

Extra spaces in help strings break the niceness gate test for
openstack-manuals (see https://review.openstack.org/#/c/77625/1).

This patch removes an extra space to ease the automatic import of config options
in the docs repository.

Change-Id: I005d0a0a260e11adf8c7bb74df3933f4f8f615d9
Prevent thrashing when deploying many bm instances

Nova BM is easily overwhelmed at the moment because it has to convert
every disk image to raw - simply deploying 2 instances at once exceeds
the IOPS on most single disk servers. Avoid this by serialising the
image conversion (which leads to a lower average-time-to-deploy in
nearly all situations).

Change-Id: I6d5ee97ffdbd497802379b13e70b84d70d8ded57
Co-Authored-By: Steve Kowalik <steven@wedontsleep.org>
Add a missing space in a log message.

It's easy to accidentally forget to add a space between words when splitting a
message up across multiple lines.  I noticed this case while working on some
other code.  Fix it up.

Change-Id: I0d714c0932834a15fb68f26f484495ccccb5a6ad
notifier middleware broken by oslo.messaging

audit middleware in oslo-incubator is incompatible with oslo.messaging.
an oslo.messaging compatible version is available in pycadf library.
remove broken oslo-incubator code in this patch.

also add middleware/request_id to openstack-common.conf so we continue
to pull in request_id middleware but not audit/notifier.

Partial-Bug: #1280327
Change-Id: I665144b256da0b04267cac754324e5779512e65d
No longer call check_uptodate.sh in pep8

check_uptodate.sh re-generates a nova.conf.sample and then compares
it, which was fine. It stopped being fine when we started pulling in
options from oslo, or other modules made releases and then the gate
broke until we fixed the config sample.

Change-Id: I04b2b52a9e46dcf5f4f06e639327f22b827ccd0d
Fixing host_ip configuration help message

The vCenter/ESXi client can only accept a hostname or IP address
and not a URL.  Fix the help message to accurately describe what
kind of address is accepted.

Change-Id: Ie90247195181189d22e727a855145313397550ca
Closes-Bug: #1274294
VMware: refactor _get_volume_uuid

It is more efficient to ask vCenter for specific extraConfig property instead
getting all properties and then manually searching the one which is
needed.

Closes-Bug: #1257726
Change-Id: I4fc8399c9a8b6a141ac489e8fb92117ec03ca42f
Fix typo in devref

s/differenet/different

Change-Id: I06bb0d9b0c5448ec5491372572e2b98dc3cea9be
Ignore the image name when booting from volume

In 0185d2445 the _run_instance method was changed to acquire the image
metadata from the request_spec instead of glance. This was needed to be
able to get the image_metadata attached to a volume, when booting from
it. That change didn't consider that the image name key is not inherited
when creating a volume from an image and introduced a bug when creating
the usage_info for volume booted instances.

This change fixes this by only attaching the image name to the usage_info
only when booting from an image and not when booting from a volume.

Related-Bug: 1281973
Change-Id: I8ec441e7815855a94a28c4566790d5144deff16f
Address the comments of the merged image handler patch

Three minor things which was commented in change:
Idce8d21ae37bfdbb28a2567120a83d1061061904

Change-Id: Idd899ec2c177c9b5695b6908bc897fe3e759beca
Signed-off-by: Zhi Yan Liu <zhiyanl@cn.ibm.com>
Merge "Add a missing space in a log message."
VMware: create datastore utility functions

The patch moves datastore interfaces from vmops and vm_util
to a separate file - ds_util.

This is part of the blueprint vmware-image-cache-management.

In the past the datastore methods would poll the task
to determine that it had completed. This has beem addressed by
making the driver _poll_task return the task information.

The patch set also solves the following bugs by checking if
the FileAlreadyExistsException exception is raised. This could
be due to another process or thread creating the file.

Closes-bug: 1230047
Closes-bug: 1254128

Change-Id: I788e33dbcb3dedc41831b976137607274b1c02ca
Merge "No longer call check_uptodate.sh in pep8"