In fact come to think of I will delete it for now. It's not a complicated class and it's not used now. it shouldn't take up the source space and potentially confuse people (by its name) 

----- Original Message -----

> From: "Patrick Huang" <pahuang@redhat.com>
> To: "zanata/zanata-server"
> <reply@reply.github.com>
> Sent: Friday, May 2, 2014 2:40:21 PM
> Subject: Re: [zanata-server] Add multiple field search in editor (#426)

> I was going to use it as Predicate in a wait for call(it only accepts
> Predicate). And I tried to make the method read better, such as:
> ```java
> waitFor(LoadingPanel.appear()); // started the ajax
> waitFor(LoadingPanel.disappear(); // loading finished
> // etc
> ```
> But in the end this class isn't used. But I still left it there thinking
> maybe will use it some other time.

> ----- Original Message -----

> > From: "Carlos Munoz" <notifications@github.com>
> 
> > To: "zanata/zanata-server" <zanata-server@noreply.github.com>
> 
> > Cc: "Patrick Huang" <pahuang@redhat.com>
> 
> > Sent: Friday, May 2, 2014 2:28:28 PM
> 
> > Subject: Re: [zanata-server] Add multiple field search in editor (#426)
> 

> > In
> > functional-test/src/main/java/org/zanata/page/webtrans/LoadingPanel.java:
> 
> > > +public class LoadingPanel implements Predicate<WebDriver> {
> 
> > > +    private final boolean appear;
> 
> > > +
> 
> > > +    public static LoadingPanel appear() {
> 
> > > +        return new LoadingPanel(true);
> 
> > > +    }
> 
> > > +
> 
> > > +    public static LoadingPanel disappear() {
> 
> > > +        return new LoadingPanel(false);
> 
> > > +    }
> 
> > > +
> 
> > > +    @Override
> 
> > > +    public boolean apply(WebDriver input) {
> 
> > > +        return appear == input.findElement(By.id("loading-panel"))
> 
> > > +                .isDisplayed();
> 
> > > +    }
> 

> > * Hmm. Not sure about this class being a Predicate. Shouldn't this be an
> > isVisible method, and let callers wrap it around a Predicate?
> 

> > —
> 
> > Reply to this email directly or view it on GitHub .
>