need to update the scaladoc above