Moved potion static functions to EntityEffect to create splash potions through the world

Caveat emptor: this *may* break a plugin that was made within the last few days and uses potions

Moved the static functions to `EntityEffect`, and made `SplashPotionEntity` take a `cItem`. This way, we can use `cProjectileEntity::Create` to spawn splash potions instead of the roundabout way that was taken before. The splash potion will generate the three fields that `cItem` replaced in the constructor. 
Indent failure. Use a single indent level, a separate line for the closing parenthesis and all params on indented lines:
```cpp
  a_Player->AddEntityEffect(
    cEntityEffect::GetPotionEffectType(PotionDamage),
    cEntityEffect::GetPotionEffectDuration(PotionDamage),
    cEntityEffect::GetPotionEffectIntensity(PotionDamage)
  );
```
(Note that GitHub webcomments force me to use spaces; use tabs to indent the code)