oo-diagnostics: Fix test_node_mco_log when no log

Make test_node_mco_log fail gracefully when the node mcollective log file
is absent.  Before this commit, the test would hang because it would run
a sed command with no input file provided.

This commit fixes bug 1077664.
oo-diagnostics: Drop unneeded require 'socket'

Drop a "require 'socket'" statement in the test_broker_certificate check.

This require statement was obviated in commit
9b72939f28a6d35354db74cc7464d879bbd3a81e.
oo-diagnostics: Better handle curl error

Catch and report if curl returns an error in the test_broker_certificate
check.

Previously, test_broker_certificate would ignore curl's return code, and so
errors connecting to the broker would turn up as backtraces when
test_broker_certificate would try to parse the output from curl.
oo-diagnostics: Fix comments for test_node_mco_log

Place comments with relevant code, consistently use proper case and
punctuation, and use whitespace for better logical grouping.
added Servlet 3 dependency

Importing this template application in Eclipse shows error as the snoop.jsp depends on the Servlet API. It will improve user first time experience.
Bug 1083197 - remove NULL's from environment variables
Merge pull request #5380 from jwhonce/bug/1093197

Merged by openshift-bot
Automatic commit of package [rubygem-openshift-origin-node] release [1.24.6-1].
Automatic commit of package [openshift-origin-cartridge-jbosseap] release [2.17.5-1].
Automatic commit of package [openshift-origin-cartridge-postgresql] release [1.24.4-1].
Automatic commit of package [openshift-origin-cartridge-mysql] release [1.24.3-1].
Automatic commit of package [rubygem-openshift-origin-controller] release [1.24.7-1].
Automatic commit of package [openshift-origin-cartridge-jbossas] release [1.24.5-1].
Bug 1094108 - show obsolete carts if ALLOW_OBSOLETE_CARTRIDGES=true
Merge pull request #5378 from lnader/master

Merged by openshift-bot
Fix formatting
Bug 1091433 - Add setting to detune GearStatePlugin

* Add sysconfig/watchman element STATE_CHECK_PERIOD to control
  frequency of running GearStatePlugin
Merge pull request #5382 from danmcp/master

Fix formatting
Merge pull request #5383 from jwhonce/bug/1091433

Merged by openshift-bot
Updated REST API docs version 1.6