Hi Brad,


The class is sealed so it can’t be inherited. I assumed intention was not to be inherited given the default CollectionTestFactory looks for the collection name in the constructor rather than a named property? I just removed the inherited parameter to align with this thinking, and to tidy up what I thought was just a typo. But yes would make more sense to allow people to name collections to suit their context. 


HTH,


Guy





From: Brad Wilson
Sent: ‎Sunday‎, ‎20‎ ‎April‎ ‎2014 ‎11‎:‎59‎ ‎a.m.
To: xunit/xunit
Cc: Guy Robinson





In src/xunit.core/CollectionAttribute.cs:
> @@ -5,7 +5,7 @@ namespace Xunit
>      /// <summary>
>      /// Used to declare a specific test collection for a test class.
>      /// </summary>
> -    [AttributeUsage(AttributeTargets.Class, AllowMultiple = false, Inherited = true)]
> +    [AttributeUsage(AttributeTargets.Class, AllowMultiple = false, Inherited = false)]


What motivated this change? We envisioned that people might want to set a category on a base test class that would be inherited.

—
Reply to this email directly or view it on GitHub.