Add cgroup mount directory names to validate output.

That file can be lengthy at times and we usually just care about cgroup
mounts right? Do you have any other use cases in mind?

On Mon, Dec 22, 2014 at 12:09 PM, Rohit Jnagal <notifications@github.com>
wrote:

> In validate/validate.go
> <https://github.com/google/cadvisor/pull/387#discussion-diff-22187032>:
>
> > @@ -194,7 +194,19 @@ func validateCgroupMounts() (string, string) {
> >  		out += desc
> >  		return Unsupported, out
> >  	}
> > +	mounts, err := ioutil.ReadDir(mnt)
> > +	if err != nil {
> > +		out := fmt.Sprintf("Could not read cgroup mount directory %s.\n", mnt)
> > +		out += desc
> > +		return Unsupported, out
> > +	}
> > +	mountNames := "\tCgroup mount directories: "
> > +	for _, mount := range mounts {
> > +		mountNames += mount.Name() + " "
>
> Good point about /proc/mounts. I think we should just add the whole output
> of /proc/mounts at end of the validate output. We ask for it while
> debugging quite a bit. WDYT?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/google/cadvisor/pull/387/files#r22187032>.
>