Support specifying Adjustment state for fetch requests

I've made a few small changes to support specifying Adjustment state for fetch requests. 

I also increased the visibility of doGET because with this visibility I would have been able to append the state parameter to a fetch URL without modifying the client code at all. 
Sure - it's a straight forward issue. I just can't determine the root
cause. Here's the dump of the runtime exception:

23:35:13,610 WARN  ~ Recurly error whilst calling:
https://api.recurly.com:443/v2/accounts/32/adjustments?type=charge%3Fstate%3Dpending&&per_page=20
<?xml version="1.0" encoding="UTF-8"?>
<error>
  <symbol>type_invalid</symbol>
  <description>Invalid type (must be one of charge, credit)</description>
</error>


As you can see, the value of the "type" parameter is being set to the
entire string from "=" to the "&&" before per_page because for some reason
the "&" and the "=" that my patch is adding to the url for the state
parameter are being  URL-encoded.
So the problem is obvious but I can't figure out what is URL encoding that
portion of the URL string. I'm certainly not explicitly doing it in my
code.  That's why in a previous email I inquired whether you could think of
any build time tasks in Maven that perhaps would result in the source being
encoded for some reason.  Any thoughts?

Cheers,


On Thu, Jul 10, 2014 at 10:53 AM, Pierre-Alexandre Meyer <
notifications@github.com> wrote:

> In src/main/java/com/ning/billing/recurly/RecurlyClient.java:
>
> > @@ -683,7 +687,7 @@ public Invoice fetchInvoice(final String recurlyToken) {
> >
> >      ///////////////////////////////////////////////////////////////////////////
> >
> > -    private <T> T doGET(final String resource, final Class<T> clazz) {
> > +    public <T> T doGET(final String resource, final Class<T> clazz) {
>
>  I completely understand the hesitation. However do consider that there
> are
>
> many API parameters that the client doesn't currently support.
>
>  Yes, but I'm hoping the library will be feature complete eventually.
>
> I'm still unable to get my
> modified getAccountAdjustments() method working.
>
> What's the issue? Do you have a stack trace?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/killbilling/recurly-java-library/pull/38/files#r14770362>
> .
>



-- 
Eric Simmerman
President | Tempest Strings Enterprises, Inc.
ets@tempeststrings.com
US Tollfree: (888) 568-8585