During the self-destruct flow (user-level Chrome being replaced by system-level Chrome), existing code to retarget shortcuts failed to update icon executables. This CL fixes this. The heuristics are summarized below:

1. Only considering shortcuts with parameters .
2. Shortcuts whose icon file == old target (user-level chrome.exe) gets updated to new target (system-level chrome.exe).
3. Shortcut index is kept same as before.

(1) lets us delete user-level (pure) Chrome shortcut since system-level Chrome shortcut is already present. (2) lets us select migrate App Launcher shortcut (points to chrome.exe), without changing app shortcuts (points to fixed .ico files). (3) prevents App Launcher shortcut from mutating into Chrome shortcut (it assumes icon resources enumeration don't change.

To make (2) and (3) possible, we need to read the icon file and icon index. This is done by generalizing ResolveShortcut() to ResolveShortcutProperties().

The new logic requires a new flow in ShellUtils, and no longer uses the UpdateShortcutsWithArgs() flow.

BUG=326562

Review URL: https://codereview.chromium.org/108193019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243642 0039d316-1c4b-4281-b951-d872f2087c98
Show "Chrome" on the tabstrip for chrome signin page

BUG=330683

Review URL: https://codereview.chromium.org/123453002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243643 0039d316-1c4b-4281-b951-d872f2087c98
Add goma include to mac GM toolchain.

Even though this isn't hooked up on Mac yet, we need the goma include for all toolchains to avoid throwing errors for Goma on Mac users.

TRB=thakis

Review URL: https://codereview.chromium.org/129323002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243644 0039d316-1c4b-4281-b951-d872f2087c98
SVN changes up to revision 243643
Fix cloud storage upload messages in page_sets/PRESUBMIT.py

The public/internal prompt had an unexpanded "%s" replacement.

Also, messages about what was being uploaded referred to the
sha1 file, while the thing actually being uploaded is the .wpr.

R=dtu@chromium.org

Review URL: https://codereview.chromium.org/126543006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243645 0039d316-1c4b-4281-b951-d872f2087c98
SVN changes up to revision 243645