Removed some TBC/WotLK code parts
[tweak] Tiny readability tweak loot code

Signed-off-by: Cala Haryon <calaftp@free.fr>
[tweak] Improved and simplified shaman healing code.

Signed-off-by: Cala Haryon <calaftp@free.fr>
[Fix] Thanks to blueboy for pointing out, last patch caused code to no longer compile. Also, intended code was functionally no different than replaced code, so switched back to old and added a TODO.

Signed-off-by: Cala Haryon <calaftp@free.fr>
[tweak] IsInDuel() more or less did what it was supposed to through chance (or clever usage, however you see it). Recoded to make it more in line with it's name/description and removed the input variable; Has more general usage to boot.

Signed-off-by: Cala Haryon <calaftp@free.fr>
[Fix] Missing player.h mod from previous commit. I swear I tested it, just not used to having modified files outside of the playerbot ones.

Signed-off-by: Cala Haryon <calaftp@free.fr>
[feature] Introduced new function 'GetHealTarget()' available to all classes. This centralizes a good section of the healing code (namely the target selection) and should be a big improvement in actual target selection. Some assumptions are made for non-bots based on talent specs, should be clear enough. The only problem might be with players using a DPS feral druid build (kitty) - the healer will focus on these players as much as the tank. Should only be a problem with players ignoring their own threat. New function is there, but as of yet unused. ToBeContinued :)

Signed-off-by: Cala Haryon <calaftp@free.fr>
[feature] Make GetHealTarget() available to healing classes

Signed-off-by: Cala Haryon <calaftp@free.fr>
[tweak] move OOC healing code for shaman above drinking/eating. As it stands, there is no pause that can be interrupted by critical eventsthus you want drinking after healing (else the drinking will be interrupted anyway)

Signed-off-by: Cala Haryon <calaftp@free.fr>
[tweak/fix] Made all HealTarget functions the same, returning CombatManeuverReturns and accepting a pointer. Achieves several things: * Achieve easy centralization should that ever become preferable * Can more easily relate one class' heal code to anothers * Clear return values that can be handled better * Fixed a few errors, and 'bad' and/or missing return values

Signed-off-by: Cala Haryon <calaftp@free.fr>
[tweak] Makeover of Druid healing code. Some reshuffling and a fix or two - mostly just removing old code and using GetHealTarget() instead.

Signed-off-by: Cala Haryon <calaftp@free.fr>
Remove compile warnings

Signed-off-by: Cala Haryon <calaftp@free.fr>
Correct logic in switch statement

Signed-off-by: Cala Haryon <calaftp@free.fr>
All warning mistakes corrected now

Signed-off-by: Cala Haryon <calaftp@free.fr>
Small typo correction ;)

Signed-off-by: Cala Haryon <calaftp@free.fr>
[tweak] Minor warrior tweaks:

Signed-off-by: Cala Haryon <calaftp@free.fr>
[fix] What is this, tiny commit day? And with comments, no less :)

Signed-off-by: Cala Haryon <calaftp@free.fr>
Compile fix - structures can't be declared locally in functions

Signed-off-by: Cala Haryon <calaftp@free.fr>
Remove more warnings

Signed-off-by: Cala Haryon <calaftp@free.fr>
Adjustments in the code to reduce the lag effect, causing the current lockup issue.

It would be wrong to call this a fix as I believe this issue is due to a combination
things. What I have found is that this and the next few commits, do appear to
improve bot responsiveness.

Signed-off-by: Cala Haryon <calaftp@free.fr>