Remove deprecated config option names: Juno Edition

Just like the beginning of every other release, remove the deprecated
config option aliases that were marked as deprecated in Icehouse.

Equivalent Icehouse patch: I64548e40f6cea42275a6f0f3ebdc0c4cd9324804

DocImpact: Configurations that were deprecated in the Icehouse release are not
recognized in Juno.

Change-Id: I346ee0248c03e60716bd7dc4a5ee4493610867cb
Delete image when backup operation failed on snapshot step

when we snapshot an instance, we will use @delete_image_on_error to
delete any failed snapshot, however, the image will not be removed
by backup code flow, it will be an issue if too many backup failed
at last ,all useful image will be removed and we have only 'error'
image left in host

Change-Id: Ib527ade86aef52a8445b57fa03fed434578c4204
Closes-Bug: #1288574
Make metadata password routines use Instance object

This replaces existing uses of raw conductor apis for get_by_uuid()
and instance_update() with objects.

Related to blueprint compute-manager-objects-juno

Change-Id: I63cf0ac6636e17f2bfcd9d6a859d9ed8612a56e1
Deprecate instance_get_by_uuid() from conductor

Aside from a few trivial-to-fix places in the unit tests, the
conductor instance_get_by_uuid() method is no longer used. This
deprecates it and cleans up the few places that were trivially
touching it.

Related to blueprint compute-manager-objects-juno

Change-Id: Iab48856c0432af0b9483e9868c2e235de75fdd51
libvirt: Make nwfilter driver use right filterref

This fixes Bug #1220856 which occurs with Libvirt NWFilterFirewall
Driver.  While creating a VM with multiple NICs including one connects
to DHCP serving network and another to DHCP non-serving network,
NWFilterFirewall Driver will use the same base filter that allows DHCP
for all NICs. This leads a libvirt launch error due to lack of
'dhcp_server' parameter which is needed to define allow-DHCP filters.

This patch makes NWFilterFirewall Driver use right base filter for
each NIC depends on 'dhcp_server' config.

Closes-bug: #1220856
Change-Id: I7f9a7c281f152985478b2ec295f0644ba475fd76
Network: add instance to the debug statement

Allocating and deallocating a network from an instance needs
more info to debug especially when more than one instance
has the same name.

The same change is also made regarding exceptions. That is,
the instance UUID will be used instead of the name.

Change-Id: I624fe77c71f6cb7ca453c863b59f0452c8e6b383
Make sure domain exists before referencing it

Before calling domain.destroy() in the exception handler for a failed
create attempt, make sure domain was created prior to when the
exception was thrown.

Change-Id: I3b7c5afce7f3bacce1b444c245b035334962ff7c
Closes-Bug: #1326998
Don't translate debug level logs in nova

Our translation policy
(https://wiki.openstack.org/wiki/LoggingStandards#Log_Translation) calls
for not translating debug level logs. This is to help prioritize log
translation. Furthermore translation has a performance overhead, even if
the log isn't used (since nova doesn't support lazy translation yet).

This is the final patch ensuring that all fines in the nova directory
no longer have translations for debug messages.

Change-Id: Ib10f5826e2238cbb2d4315c48be570eb31b2ea55
Fix object leak in nova.tests.objects.test_fields.TestObject

Call superclass's setUp() before defining new objects so that the object
registry can be saved, and later restored, without the test objects in
it.  This prevents the objects leaking into other tests by way of the
object registry.

Change-Id: If71a055c28c1875e67d826c5c4affda7377d179d
Fix object change detection

The current object change detection actually just hashed the method
argspecs of the remotable decorators instead of the wrapped methods
themselves. This patch fixes that by stashing a pointer to the
original function, which is used for the hash and will be useful
for other inspection-related tasks as well.

This also adds a utility to help when regenerating the hashes,
similar to what we do for API samples. Running the unit tests like
this will give you an object_hashes.txt output file:

  GENERATE_HASHES=y tox TestObjectVersions

Change-Id: Icfe4d6c08f42296c756d1f9ab7c88b52e3209d84
Merge "Fix object leak in nova.tests.objects.test_fields.TestObject"
Merge "Fix object change detection"
Merge "Make metadata password routines use Instance object"
Merge "Deprecate instance_get_by_uuid() from conductor"
Merge "Remove deprecated config option names: Juno Edition"
Merge "libvirt: Make nwfilter driver use right filterref"
Merge "Don't translate debug level logs in nova"
Merge "Network: add instance to the debug statement"
Merge "Make sure domain exists before referencing it"
Merge "Delete image when backup operation failed on snapshot step"