Not really sure what you mean, but from what I can see in fromConstInitializer it does not modify argument e (second argument) in any way. The return values are not used in the visit(CmpExp *e) method and should be redundant.