Dependency Updates and Base64 Encoding protection

added protection for issue #164 so it is obvious as to why waffle dislikes unexpected authentication headers.

Updated jetty and tomcat versions.

Some minor code enhancement seen while looking around for good type of error to use for the encoding issue fix based on logic of waffle.

Removal of deprecated base64 used in waffle 1.6 and earlier.

Keeping on the maven dependency update train!
I agree with specialized exception.  There are other runtime exceptions in waffle that are somewhat similar.  Now I believe sonar complains when throwing these so will circle back and get them all later when I scan again.

--- Original Message ---

From: "Daniel Doubrovkine (dB.) @dblockdotorg" <notifications@github.com>
Sent: November 17, 2014 7:48 AM
To: "dblock/waffle" <waffle@noreply.github.com>
Cc: "Jeremy Landis" <jeremylandis@hotmail.com>
Subject: Re: [waffle] Dependency Updates and Base64 Encoding protection (#166)

> @@ -68,7 +68,11 @@ public String getToken() {
>      }
>
>      public byte[] getTokenBytes() {
> -        return BaseEncoding.base64().decode(getToken());
> +        try {
> +            return BaseEncoding.base64().decode(getToken());
> +        } catch (IllegalArgumentException e) {
> +            throw new RuntimeException("Invalid authorization header.");

I almost feel like this should be a specialized exception, but it's not a big deal.

---
Reply to this email directly or view it on GitHub:
https://github.com/dblock/waffle/pull/166/files#r20432999