Update org.pegdown:pegdown to 1.2.1

Change-Id: I1a4974b621d689ffd41073e1f1b140352c45aa1b
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
Remove @VisibleForTesting from ChangeData

The bulk reindex program for gerrit-review uses this constructor.
Drop the annotation saying it is only for testing.

Change-Id: Ie93bc68914bd332cd154c4d884bc6fb7b902baec
Pass only Change.Id for async background indexing

The background worker thread creates its own database connection
to read the record. The change could have been modified between
the time it is enqueued, and the time the indexing is processed.
Always read from the database in the background thread to ensure
the index gets the most recent possible data.

This may fix some index state errors on gerrit-review (and friends).

Change-Id: Ifab8d0ba7c9dcac54b7e168b86e9a82a3c681ea5
SideBySide2: Bind shift-{n,p} to navigate comments

The old screen supported N and P to jump to next and previous
comments in the file, similar to n and p moving over modified
regions.

Bind shift-n and shift-p to navigate through comments.

Change-Id: I8fb788f438987e2448d39b62ced1e7615d32546e
SideBySide2: Add shift-m to mark reviewed and open next file

In the old UI "M" marked the reviewed flag (if not already set)
and moved to the next file in the change. Implement a similar
behavior in the new SideBySide2 UI.

Bind as "shift m" instead of "M" due to vim mode using lowercase
"m" as a mark character, which some users may actually use to make
bookmarks during a review.

Change-Id: I1e7780e6265fa3380aae09c034583dec7ec4830a
SideBySide2: Track SkipBar instances by the starting line

Use a SortedMap to track the SkipBars, indexed by first line number
hidden by the bar. This simple refactoring allows for a future
change to find if a line is covered by a skip bar.

Change-Id: Iee71856e0c24140a10c0ee4938abfcef6490d6e9
Merge "SideBySide2: Track SkipBar instances by the starting line"
ChangeScreen2: Make commit sha1 copyable

Make Commit-Id copyable similar to Change-ID
so that users can easily copy it.

Feature: Issue 2191
Change-Id: I5f0e955432307f8c32c733ea7e0ed2568c4dd82d
SideBySide2: Fix up first line handling in scroll synchronizer

When a line is inserted at the start of the file the A side inserts a
padding widget above the line.  CM3 doesn't always include this widget
height in the heightAtLine() computation on the A side, causing the
files to become unaligned after scrolling down and then back up.

Special case the 0th line in the editors by assuming these will be
aligned at the very top of the page on either side and just use pixel
coordinates.

Change-Id: I91f7d8afe89fa7c22ec4dcf385d24a4a8d284421
SideBySide2: Trim empty line from end of range selection

When creating a new comment on a selected region, trim off any empty
line at the end of the selection.

This fixes a common problem when the user has selected an entire
paragraph of text and finished the selection at the start of the next
line, which logically appears to be the end of the paragraph.
Comments were inserting below this empty line, as the empty line was
set as the end of the range.

Change-Id: Ib5fc67f5a0c563b701c84d92e11886e0116e3a73
Merge "Update org.pegdown:pegdown to 1.2.1"
Add MessageOfTheDay extension point for plugins

Allow plugins to contribute messages to the UI during initial page
load. Gerrit displays the messages in a butter bar at the top of
the page and allows users to hide them with the "Dismiss" button.

Messages are hidden per-browser using a cookie named after the
message id, set to expire at a date supplied by the server. After
this date the same message could redisplay if the server sends the
same message again.

Change-Id: I0bcca845f501cbeb8c31356fff398c3adb43099a
Merge "SideBySide2: Fix up first line handling in scroll synchronizer"
Merge "SideBySide2: Trim empty line from end of range selection"
SideBySide2: Expand skipped regions on search result matches

Allow CM3 to expand an entire skipped region of a single
search result is found within the region.

Change-Id: Iaaf139a2ff9a0d7a2c018b7195d093eac1634ab2
Merge "SideBySide2: Expand skipped regions on search result matches"
Revert "SideBySide2: Track SkipBar instances by the starting line"

This reverts commit 1df5a8f00fbe69ec3b386ed3487a2ae0c229a966.

Tracking the bar using a SortedMap is not necessary.  The skip
bars are removed automatically by CM3 now when search enters into
a skipped region.

Change-Id: Ia3194692c7a8e7c098bc97d9dc2ebd3fa89fc5ca
SideBySide2: Fix SkipBar expansion to cleanup SkipManager

When CM3 enters a skipped region the bars are removed. They also
must be removed from the SkipManager's collection.

Do not modify the CM3 selection when CM3 enters a skipped region.
This should only attempt to happen during a user click in the bar.

Change-Id: Ieebde1e1b1bdd9e4714849165def65e65b55668e
Change the color of green for ~ in related changes.

The previous color looked too neon and this is a darker green.

Change-Id: Ief3d668b01efa73262b726f657467ff080419ff5
Fix grammar error in GetDiff

Change-Id: Ie3f51e93c1fe5b13a000fcc9ecc9372762755e14