almost done with spec for Share