Please also leave a comment explaining that this is to fix a Firefox issue,
but it's also reasonable to never send data on DELETEs.


On Thu, Jan 2, 2014 at 11:05 AM, Caleb Mingle <notifications@github.com>wrote:

> In vendor/assets/javascripts/brainstem/brainstem-sync.coffee:
>
> > @@ -58,7 +58,7 @@ Backbone.sync = (method, model, options) ->
> >          beforeSend.apply this, arguments
> >
> >    # Don't process data on a non-GET request.
> > -  if params.type != 'GET' && !options.emulateJSON
> > +  if params.type != 'GET' && !options.emulateJSON && params.type != 'DELETE'
>
> Should probably strip the data on all delete requests.
>
> if params.type == 'DELETE'
>   params.data = null
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/mavenlink/brainstem-js/pull/17/files#r8619943>
> .
>



-- 
Andrew Cantino
VP of Engineering, Mavenlink