Cleaning Up CFile

Incorporating the changes in PR #2596 
You are right! I didn't realise that it had a dummy implementation for bool
and just empty for the rest of the types. I have no idea why it was done
like that, but I am good with the way you are doing it now with a dummy
implementation for all data types.

On 21 November 2014 09:16, Abhinav Agarwalla <notifications@github.com>
wrote:

> In src/shogun/io/File.cpp:
>
> > @@ -193,6 +426,64 @@ char* CFile::get_variable_name()
> >  	return strdup(variable_name);
> >  }
> >
> > +#define STRING_LIST_GETTER(type)									\
> > +void CFile::get_string_list(										\			
>
> Sorry, I completely misunderstood.
> Earlier before this patch dummy function was implemented for only bool
> type argument, but since I used Macros instead, the dummy definition was
> used.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/shogun-toolbox/shogun/pull/2616/files#r20702868>.
>