Fix inverted logic in samba configuration generation that prevents
shadow copy working for child dataset when parent have recursing
periodic snapshots.

While I'm there also split the zfs list out of the loop becuase it
is invariant during the loop.

Ticket:	#4350