work on controller