131 names refactor part iv

testing: AgentConfigForTag now takes a names.Tag not a string.

Resolving the type of the tag returned from AgentConfig.Tag() will require more effort.
On Wed, Jul 9, 2014 at 3:11 PM, Menno Smits <notifications@github.com>
wrote:

> In state/api/provisioner/provisioner_test.go:
>
> > @@ -630,7 +629,7 @@ func (s *provisionerSuite) TestTools(c *gc.C) {
> >  	s.machine.SetAgentVersion(cur)
> >  	// Provisioner.Tools returns the *desired* set of tools, not the
> >  	// currently running set. We want to be upgraded to cur.Version
> > -	stateTools, err := s.provisioner.Tools(s.machine.Tag().String())
> > +	stateTools, err := s.provisioner.Tools(s.machine.Tag().(names.MachineTag))
>
> shouldn't machine.Tag() return a names.MachineTag instead of just
> names.Tag?
>
Yes, but currently all the state subobject things (not a real word) have to
confirm to a Taggable interface which defines they have a `Tag() names.Tag`
function. I want to change them to return the correct type, but that means
removing the Taggable interface. I don't think it's going to be hard, just
not done (yet)


> —
> Reply to this email directly or view it on GitHub
> <https://github.com/juju/juju/pull/265/files#r14693794>.
>