Missed the comment. I did a similar change and pushed though.
Den 16 jan 2014 12:55 skrev "Andreas Zelend" <notifications@github.com>:

> In xbmc/video/PlayerController.cpp:
>
> > +          SPlayerSubtitleStreamInfo info;
> > +          g_application.m_pPlayer->GetSubtitleStreamInfo(CMediaSettings::Get().GetCurrentVideoSettings().m_SubtitleStream, info);
> > +          if (!g_LangCodeExpander.Lookup(lang, info.language))
> > +            lang = g_localizeStrings.Get(13205); // Unknown
> > +
> > +          if (info.name.length() == 0)
> > +            sub = lang;
> > +          else
> > +            sub = StringUtils::Format("%s - %s", lang.c_str(), info.name.c_str());
> > +        }
> > +
> > +        CGUIDialogKaiToast::QueueNotification(CGUIDialogKaiToast::Info, g_localizeStrings.Get(287), sub, DisplTime, false, MsgTime);
> > +        return true;
> > +      }
> > +
> > +      case ACTION_CYCLE_SUBTITLE:
>
> This should suffice:
>
>   xbmc/video/PlayerController.cpp | 10 ++++++++--
>  1 file changed, 8 insertions(+), 2 deletions(-)
> diff --git a/xbmc/video/PlayerController.cpp b/xbmc/video/PlayerController.cppindex 4cfb3ea..e2f1b89 100644--- a/xbmc/video/PlayerController.cpp+++ b/xbmc/video/PlayerController.cpp@@ -52,6 +52,7 @@ bool CPlayerController::OnAction(const CAction &action)
>  {
>    const unsigned int MsgTime = 300;
>    const unsigned int DisplTime = 2000;+  bool cyclesubs = false;
>
>    if (g_application.m_pPlayer->IsPlayingVideo())
>    {@@ -84,6 +85,8 @@ bool CPlayerController::OnAction(const CAction &action)
>          return true;
>        }
> +      case ACTION_CYCLE_SUBTITLE:+        cyclesubs = true;
>        case ACTION_NEXT_SUBTITLE:
>        {
>          if (g_application.m_pPlayer->GetSubtitleCount() == 0)@@ -98,8 +101,11 @@ bool CPlayerController::OnAction(const CAction &action)
>            if (CMediaSettings::Get().GetCurrentVideoSettings().m_SubtitleStream >= g_application.m_pPlayer->GetSubtitleCount())
>            {
>              CMediaSettings::Get().GetCurrentVideoSettings().m_SubtitleStream = 0;-            CMediaSettings::Get().GetCurrentVideoSettings().m_SubtitleOn = false;-            g_application.m_pPlayer->SetSubtitleVisible(false);+            if (cyclesubs)+            {+              CMediaSettings::Get().GetCurrentVideoSettings().m_SubtitleOn = false;+              g_application.m_pPlayer->SetSubtitleVisible(false);+            }
>            }
>            g_application.m_pPlayer->SetSubtitle(CMediaSettings::Get().GetCurrentVideoSettings().m_SubtitleStream);
>          }
>
>
> Now cycle will disable subs when called for the last sub and next will
> advance to the first sub.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/xbmc/xbmc/pull/4030/files#r8929094>
> .
>