feedback one

edit implementation and test.