tmf: Don't use assumeTrue() in @BeforeClass in ctfadaptor tests

The behavior of a failed assumeTrue() placed within a @BeforeClass
method is really inconsistent between Eclipse and Maven. It can lead
to test failures, when it should really only skip the class.

Change-Id: Ibcd42a56ffd6280ad6682a57c587ddcd2a634e3f
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/22697
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
IP-Clean: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Systemtap: Fix "View Definition" (Function view).

Right-clicking a function in the Function view now correctly
displays the "View Definition" command in a context menu, and
the command's functionality has been restored (it now opens the
file where the chosen function is defined).

Note that the "View Definition" command has not yet been restored
for probes in the Probe Alias.

Change-Id: Ia431b56c87f2487f92bcc0b6b1437e316e643118
Signed-off-by: Andrew Ferrazzutti <aferrazz@redhat.com>
Reviewed-on: https://git.eclipse.org/r/22699
Reviewed-by: Sami Wagiaalla <swagiaal@redhat.com>
IP-Clean: Sami Wagiaalla <swagiaal@redhat.com>
Tested-by: Sami Wagiaalla <swagiaal@redhat.com>
Systemtap: Improvements to stap view icons.

Make changes to the image provider for the
Function, Probe Alias, and Kernel Source views,
so that more appropriate icons may be displayed.

Change-Id: I3be6ec110d0773d57f626f5bcc7576bb33b7e14c
Signed-off-by: Andrew Ferrazzutti <aferrazz@redhat.com>
Reviewed-on: https://git.eclipse.org/r/22701
Reviewed-by: Sami Wagiaalla <swagiaal@redhat.com>
IP-Clean: Sami Wagiaalla <swagiaal@redhat.com>
Tested-by: Sami Wagiaalla <swagiaal@redhat.com>
gdbtrace: Prevent hang when a lot of commands are sent to GDB

This can happen when commands are sent to GDB on the UI thread
and the GDB traces console gets full. The UI thread is responsible of
doing the "flush" of the console buffer so if the UI thread waits for
the flush it will wait for itself forever. The solution is to not send
GDB commands on the UI thread.

Bug: 415728
Change-Id: I6eacb9680f4966183a24c5ad915e4ddff256f40d
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/23019
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
gdbtrace: Fix table scrolling back to beginning

Instead of selecting the frame at the end of the populate cache,
select the frame at the end of indexing.

Change-Id: I1974ed4fc3a0c07ca2447f72f3888ea9d58505ff
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/23151
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
ctf: Specify a timeout for the CTF testsuite download

The default timeout of the Ant "get" task is reasonable, but the
default for "exec" (which we use for pulling the CTF testsuite) feels
like 5 minutes. This makes building offline, or behind a proxy, a bit
more painful.

Shorten the delay to 20 seconds.

Change-Id: Ic0751330c4c747fee4344d549257f7a6ab556d0d
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/23070
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
IP-Clean: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
tmf: Export xychart packages in tmf.ui

Change-Id: I93f3e10617e8a061a686313926434e163aa6ce81
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/22046
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
IP-Clean: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Hudson CI
tmf: Cancel modules when disposed

When running org.eclipse.linuxtools.lttng.alltests, the uml tests wait
forever because an analysis is running and never gets canceled. I think
modules should get canceled when disposed.

Change-Id: I745c32eae93ffad41e107ef8c29d02001d76e288
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/23168
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
IP-Clean: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Hudson CI
tmf: reactivate persistent experiment index

The assignment of the traces of an experiment where moved after the
super.initialize() method call. This lead to the in-memory being used
instead of the persistent index.

Change-Id: I4280929453a3f3f951f1e6897c4b72511c547517
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/23242
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
IP-Clean: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Hudson CI
TMF: Add the possibility to set properties on analysis outputs

Change-Id: If77d58ccb7d8105d9600e6a673e1c1392e944425
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/23145
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
IP-Clean: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
TMF: Force getId() from IAnalysisModule to be NonNull

Change-Id: I5658b167767fc17bfda397aeee1623ae1f053a80
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/23146
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
IP-Clean: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Hudson CI
TMF: Add possibility to add new module listener to analysis manager

Also cleanup the source and output initialization

Change-Id: I61f363a798734757f9ac3d991a34fd0c13ee6143
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/23153
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
IP-Clean: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
TMF: Fix a NPE when no tracetype extension is specified in UI for experiment

Change-Id: I026ae7249716e06d5612cf428f4180deec51caac
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/23281
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
IP-Clean: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Hudson CI
gdbtrace: Remove unused import

Change-Id: Ie808fe5f2b590e3560c328f486525c59597970a1
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/23286
Tested-by: Hudson CI
tmf: fix minimum total size in AttributeTree

The fix will prevent that the state system for the experiment
statistics is rebuild every time.

Change-Id: I7c494d3a515bc16ea9313ece370b727fd4947e6c
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/23244
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
tmf: remove warning in HistogramBucket class

Change-Id: I980b64e880ed434ee83bd5ce2f2252ff8eb42fe8
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/23323
Reviewed-by: Xavier Raynaud <xavier.raynaud@kalray.eu>
IP-Clean: Xavier Raynaud <xavier.raynaud@kalray.eu>
Tested-by: Xavier Raynaud <xavier.raynaud@kalray.eu>
TMF: Add rebuild() method to abstract time graph view

It is useful when some action in the view requires the view to rebuild the
list of entries, for a same trace.

This patch also adds a getPresentationProvider() method to the time graph
view so concrete classes may make changes to the presentation provider.

Change-Id: Ida104642607b98d4d285bcc54a8e86dd73602506
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/23147
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
IP-Clean: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Hudson CI
TMF: Change cast in analysis output to fix warning in luna

Change-Id: Id5cd7be0d4eb65f6ae793f8de50555ef056062df
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/23279
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
IP-Clean: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Hudson CI
Use jacoco 0.6.5.

Change-Id: I9ba223622626d7341f8fe912d69dc26e7e0d1ccb
Reviewed-on: https://git.eclipse.org/r/23321
Tested-by: Hudson CI
Reviewed-by: Alexander Kurtakov <akurtako@redhat.com>
IP-Clean: Alexander Kurtakov <akurtako@redhat.com>
Tested-by: Alexander Kurtakov <akurtako@redhat.com>
tmf: don't execute statistics analysis module for experiments

because it's not used.

Change-Id: I6ac3a898ad720c99a751893c7738dda2a9ce85b8
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/23316
Tested-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
IP-Clean: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>