Totally agreed on that!


On Wed, Apr 30, 2014 at 2:48 PM, Lee moon soo <notifications@github.com>wrote:

> In
> zeppelin-driver-jdbc/src/main/java/com/nflabs/zeppelin/driver/jdbc/JDBCConnection.java:
>
> > +
> > +	public JDBCConnection(Connection connection) {
> > +		this.connection = connection;
> > +	}
> > +
> > +	@Override
> > +	public boolean isConnected() throws ZeppelinDriverException {
> > +		try {
> > +			return connection.isClosed();
> > +		} catch (SQLException e) {
> > +			throw new ZeppelinDriverException(e);
> > +		}
> > +	}
> > +
> > +	@Override
> > +	public void close() throws ZeppelinDriverException {
>
> JDBC driver API in Java, Connection.close() raise SQLException by default.
> But right, don't need to follow JDBC if that way is bad.
>
> But to handle this problem,
> it's better be in separate issue and PR. because changing that lead
> changing all driver implementations.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/NFLabs/zeppelin/pull/46/files#r12129481>
> .
>



-- 
--
Kind regards,
Alexander.