[JENKINS-24763] Prevent thread starvation in OldDataMonitor by reducing scope of synchronization

Supercedes #1399 
Can use a plain `for` loop since we are not calling `it.remove()`.