Fix concurrency bug.

Commit d525a0cededab9eff43d7597a3593d843428a68b introduces a bug into
the -1/--no-concurrency option that causes only tests exculsively marked
as non-concurrent to be run.

This patch addresses that bug, by adding all tests to a pool with a
single thread, rather than only adding the tests explicitly requesting serial
run when using the -1/--no-concurrency

bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=73018
Tested-by: Vinson Lee <vlee@freedesktop.org>
Signed-off-by: Dylan Baker <baker.dylan.c@gmail.com>
fbo-generatemipmap-formats: Fix uninitialized variable warnings.

Fix GCC maybe-uninitialized warnings.

fbo-generatemipmap-formats.c: In function 'test_format':
fbo-generatemipmap-formats.c:112:15: warning: 'format' may be used uninitialized in this function [-Wmaybe-uninitialized]
   glTexImage2D(GL_TEXTURE_2D, i, internalformat,
               ^
fbo-generatemipmap-formats.c:80:15: note: 'format' was declared here
  GLenum type, format;
               ^
fbo-generatemipmap-formats.c:112:15: warning: 'type' may be used uninitialized in this function [-Wmaybe-uninitialized]
   glTexImage2D(GL_TEXTURE_2D, i, internalformat,
               ^
fbo-generatemipmap-formats.c:80:9: note: 'type' was declared here
  GLenum type, format;
         ^
Signed-off-by: Vinson Lee <vlee@freedesktop.org>
Reviewed-by: Chad Versace <chad.versace@linux.intel.com>
clipflat: Fix uninitialized variable warning.

Fix GCC maybe-uninitialized warning.

clipflat.c: In function 'reportFailure.isra.0':
clipflat.c:374:10: warning: 'd' may be used uninitialized in this function [-Wmaybe-uninitialized]
  snprintf(msg1, sizeof(msg1), "clipflat: Failure for %s(%s),"
          ^

Signed-off-by: Vinson Lee <vlee@freedesktop.org>
Reviewed-by: Chad Versace <chad.versace@linux.intel.com>
fbo-depthstencil: Fix uninitialized variable warning.

Fix GCC maybe-uninitialized warning.

fbo-depthstencil.c: In function 'piglit_display':
fbo-depthstencil.c:483:2: warning: 'res' may be used uninitialized in this function [-Wmaybe-uninitialized]
  return res;
  ^

Signed-off-by: Vinson Lee <vlee@freedesktop.org>
Reviewed-by: Chad Versace <chad.versace@linux.intel.com>
fbo-depth: Fix uninitialized variable warning.

Fix GCC maybe-uninitialized warning.

fbo-depth.c: In function 'piglit_display':
fbo-depth.c:314:2: warning: 'res' may be used uninitialized in this function [-Wmaybe-uninitialized]
  return res;
  ^

Signed-off-by: Vinson Lee <vlee@freedesktop.org>
Reviewed-by: Chad Versace <chad.versace@linux.intel.com>
piglit-resume.py: Fix bug in resume

This patch removes an additional JSONWriter.close_dict() call. This
extra call closed the tests dictionary after writing the tests from the
run into it; meaning when the JSONWriter instance is passed into
TestProfile.run() the tests dictionary is already closed and new tests
are not written into the root dictionary.

Reviewed-by: Chad Versace <chad.versace@linux.intel.com>
Signed-off-by: Dylan Baker <baker.dylan.c@gmail.com>
framework/status.py: Fix pep8 errors

This corrects whitespace problems.
piglit-resume.py: pep8 fixes

This fixes pep8 whitespace errors

Signed-off-by: Dylan Baker <baker.dylan.c@gmail.com>
piglit-summary.py: pep8 fixes

Fix pep8 whitespace errors

Signed-off-by: Dylan Baker <baker.dylan.c@gmail.com>
framework/core.py: pep8 fixes

fixes pep8 whitespace errors

Signed-off-by: Dylan Baker <baker.dylan.c@gmail.com>
gl-3.2-depth-tex-sampling: fix the test to expect "red" depth samples

I missed the language in section 3.8.7 about depth texture sampling.
Thanks, Marek.

Reviewed-by: Marek Olšák <marek.olsak@amd.com>
tests/util: Link with rt if PIGLIT_HAS_POSIX_CLOCK_MONOTONIC

If PIGLIT_HAS_POSIX_CLOCK_MONOTONIC, piglit-util.c will use clock_gettime,
so, make sure to link against -lrt, too.

Signed-off-by: Daniel Kurtz <djkurtz@chromium.org>
Tested-by: Brian Paul <brianp@vmware.com>
NV_conditional_render: glBeginConditionalRenderNV begin zero

INVALID_VALUE should be genrated instead of INVALID_OPERATION

Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>
fbo-bind-renderbuffer:  Expect INVALID_OPERATION error instead of INVALID_VALUE

The spec clearly requires INVALID_OPERATION, so add a quotation from the
spec.

Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>
depthstencil-render-miplevels: Add missing extension checks

Signed-off-by: Ian Romanick <ian.d.romanick@intel.com>
Reviewed-by: Brian Paul <brianp@vmware.com>
sparse-samplers: Add missing extension checks

Signed-off-by: Ian Romanick <ian.d.romanick@intel.com>
Reviewed-by: Brian Paul <brianp@vmware.com>
arb_fragment_program: Fix several copy-and-paste errors in minmax test

1. The extension check was wrong: GL_ARB_vertex_program instead of
GL_ARB_fragment_program.

2. The program query was wrong: GL_VERTEX_PROGRAM_ARB instead of
GL_FRAGMENT_PROGRAM_ARB.

3. The limit for GL_MAX_PROGRAM_ADDRESS_REGISTERS_ARB was wrong: 1 (the
vertex program limit) instead of 0.

Signed-off-by: Ian Romanick <ian.d.romanick@intel.com>
Reviewed-by: Brian Paul <brianp@vmware.com>
texwrap: Add missing extension checks

Also update the setting of has_texture_swizzle.

Signed-off-by: Ian Romanick <ian.d.romanick@intel.com>
Reviewed-by: Brian Paul <brianp@vmware.com>
fbo-incomplete: Fix GCC format-security warnings.

This patch fixes these GCC warnings.

fbo-incomplete.cpp: In function ‘bool invalid_1d_array_layer()’:
fbo-incomplete.cpp:304:57: warning: format not a string literal and no format arguments [-Wformat-security]
fbo-incomplete.cpp: In function ‘bool invalid_2d_array_layer()’:
fbo-incomplete.cpp:331:57: warning: format not a string literal and no format arguments [-Wformat-security]
fbo-incomplete.cpp: In function ‘bool invalid_cube_array_layer()’:
fbo-incomplete.cpp:358:57: warning: format not a string literal and no format arguments [-Wformat-security]

Signed-off-by: Vinson Lee <vlee@freedesktop.org>
Reviewed-by: Brian Paul <brianp@vmware.com>
tests/util: Link with rt only if librt exists.

This patch fixes the OpenBSD build.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=73332
Signed-off-by: Vinson Lee <vlee@freedesktop.org>
Reviewed-by: Brian Paul <brianp@vmware.com>