xml is done all proper