done implementing controls working on select