Remove unused definition in network base.py

The definition os = clients.Manager(interface=cls._interface) has been
replaced by os = cls.get_client_manager().

Change-Id: Idaa33c8f90de901362d6b5a01719dd0be2e700b4
Cleanup subnet creation in network api tests

This commit accomplishes 2 things, first it deduplicates the subnet
creation code by changing test_create_update_delete_network_subnet()
to use the common create_subnet() class method. Secondly the common
create_subnet() method is changed to properly use else after the for
loop instead of what was done before.

Change-Id: I04b0516e03eeb8b8f95d72259aa78f573db6ae45
Move ipv6 config option into network-feature-enabled

This commit moves the ipv6 option into the proper config group.
Previously, there was an ipv6_enabled option under the network group.
This was the incorrect location for this type of option since, ipv6
is an optional feature it should be in the feature enabled group.

Change-Id: I35769cf4d18363fad56ed5150b4d01d8a5ad17e7
Fix invalid syntax in HOT templates

This patch fixes invalid syntax in HOT templates where keywords
starting with uppercase characters are used (e.g. 'Type') in
the resources section. According to the HOT spec, though, those
keywords are all lowercase (e.g. 'type').

Change https://review.openstack.org/#/c/73580 in heat adds
stricter validation which makes the respective testcases fail.

Change-Id: Iffb79e5bb362bfd02b028166ce6ddfa616f2909f
Closes-Bug: #1288114
Prepare for enabling H302 rule (api/volume,tempest/*)

We can use H302 rule but ignore it now. This commit prepares for
enabling H302 rule. But this commit modifies a part of Tempest only
because if we fix all of them at one time, it's hard to merge this
commit.
    ---------------
    tempest/api/compute/admin
    tempest/api/compute/{c*,f*,i*,s*,t*}
    tempest/api/compute/{v3,volumes},data_processing
    tempest/api/identity/admin
    tempest/api/image
    tempest/api/{n*,o*,t*}
    tempest/api/volume,tempest/*     <- This patch
    tempest/services/compute/json
    tempest/services/compute/v3/json
    tempest/services/compute/xml
    tempest/services/identity
    tempest/services/{im*,n*,o*,t*}
    tempest/services/volume
    tempest/clients.py: TBD
    ---------------

Change-Id: I65e9ac5678d17f31de5449017f2193f53c74c535
Add Trove (database) Flavor API Tests

Added Trove (database) service and flavor API tests.

Partially implements blueprint: trove-tempest
Change-Id: Ic4c43bd42fba96950b26232a37bcf300e1e742d1
Add multiple negative test generator support

In order to support different generator styles and sets of tests
a new configuration parameter is introduced to define the negative
test generator class. This can be used to define generators that create
only random values (random fuzzy test) or pattern based values.
With this functionality it is also possible to reduce the amount
of negative tests that are automatically produced.

Change-Id: Icfad55d1eea92dc2a42642b37d34c253c26c0846
Partially-implements: bp fuzzy-test
Skip nova cli tests with volumes if Cinder unavailable

The nova cli tests for volumes will fail if Cinder is
not being tested. As it is allowable to skip Cinder tests,
we should skip these tests in that eventuality.

Change-Id: Ia3c82d416962dad446390b82780978ddaf03f1b2
Closes-Bug: #1288373
ServerCfnInitTestJSON wait for stack complete before ssh

ssh connection has a default timeout of 300 seconds but
boot times of ~250 seconds have been observed so this is
failing for a proportion of runs.

This change waits for the entire stack to be in CREATE_COMPLETE
instead of just the server resource. This means the ssh daemon
will definitely be running when ssh is attempted.

Change-Id: Iab1c797b456c6bd46283a7348896a79ebc41d7e1
Closes-Bug: #1288993
Merge "Cleanup subnet creation in network api tests"
Raise orchestration build_timeout to 600 seconds

Observed boot time for a single server has been around 250 seconds
so a build_timeout default of 300 would explain why ~20% of heat-slow
jobs are failing with stack timeout errors.

Closes-Bug: #1288970
Change-Id: I4feb1b89acf8db0e164468d0471aff71ff5c6a77
Merge "Add Trove (database) Flavor API Tests"
Merge "Fix invalid syntax in HOT templates"
Merge "Prepare for enabling H302 rule (api/volume,tempest/*)"
Merge "Raise orchestration build_timeout to 600 seconds"
Merge "Move ipv6 config option into network-feature-enabled"
Volume backup details API test

This patch adds volume_backup_details vlolume API Test.
It also changes assertEqual() function to correct one, where
first parameter will be expected and other is actual.

Change-Id: I579cc5c913f4744e69cbd2a0df8eb2f198bb7a8b
Merge "Skip nova cli tests with volumes if Cinder unavailable"
Merge "Volume backup details API test"
Merge "ServerCfnInitTestJSON wait for stack complete before ssh"