On Tue, Apr 8, 2014 at 10:05 AM, Blake Griffith <notifications@github.com>wrote:

> In distarray/tests/test_utils.py:
>
> > @@ -16,14 +16,18 @@ class TestMultPartitions(unittest.TestCase):
> >      Test the multiplicative parition code.
> >      """
> >
> > -    def test_both_methods(self):
> > -        """
> > -        Do the two methods of computing the multiplicative partitions agree?
> > -        """
> > -        for s in [2, 3]:
>
> create_factors isn't so simple, it calls out to two other functions.
> Which themselves should be tested. It is complicated enough to warrant its
> own tests. And I'm not sure writing meta-tests for functions only used in
> tests is worthwhile.
>

Given unlimited resources, we'd do the full testing with multiple versions,
etc.  @markkness feel free to make a wishlist issue with your testing
ideas, but otherwise, I'm +1 on just testing the factorisation function in
use and removing the others.


>  I also deleted one of the functions create_factors called, divisors. And
> another that just wasn't used anywhere.
>
> --
> Reply to this email directly or view it on GitHub<https://github.com/enthought/distarray/pull/274/files#r11393841>
> .
>



-- 
Kurt W. Smith, Ph.D. <ksmith@enthought.com>
Enthought, Inc. <http://www.enthought.com>  | 512.536.1057