[RFC] remove vim_round() in favour of round()

C89 did not have round(), vim emulated it with vim_round. But since we're using C99 this is not a problem anymore.

This conflicts a tiny bit with the profiling PR (#839), I'll rebase whichever one gets merged second.
On July 4, 2014 12:24:53 AM GMT+03:00, Nicolas Hillegeer <notifications@github.com> wrote:
>> @@ -12186,7 +12177,7 @@ static void f_round(typval_T *argvars,
>typval_T *rettv)
>>  
>>    rettv->v_type = VAR_FLOAT;
>>    if (get_float_arg(argvars, &f) == OK)
>> -    rettv->vval.v_float = vim_round(f);
>> +    rettv->vval.v_float = round(f);
>
>You're right. Arguably this was a bit of an implementation error of
>`vim_round()` (or not, signed 0 is tricky business anyway). The
>question is, indeed, whether anyone was relying on this.
>
>As the master of seemingly impossible vimscript features that people
>are using, I'd like to call on @ZyX-I.
>
>---
>Reply to this email directly or view it on GitHub:
>https://github.com/neovim/neovim/pull/909/files#r14536110

Except for lua where I do not have a choice I use floats only for math. More, I do not know any built-in sources for floats that may produce exploitable hacks involving floats.