fix wrong printf format mismatches

As the title said this hunts all printf format mismatches (thanks @notspiff)
the problem is needing 5 lines of code to silence a warning, which would 
have been fine in case it's actually warning about something valid, but 
in this case, it's just adding more code and has 0 effect. was thinking 
about always adding the sequence number here, even when there's only one 
instance of a device and getting rid of the special case

On 30-09-14 10:34, Sascha Woo wrote:
>
> In xbmc/peripherals/devices/Peripheral.cpp:
>
> > @@ -55,10 +55,16 @@ CPeripheral::CPeripheral(const PeripheralScanResult& scanResult) :
> >  {
> >    PeripheralTypeTranslator::FormatHexString(scanResult.m_iVendorId, m_strVendorId);
> >    PeripheralTypeTranslator::FormatHexString(scanResult.m_iProductId, m_strProductId);
> > -  m_strFileLocation = StringUtils::Format(scanResult.m_iSequence > 0 ? "peripherals://%s/%s_%d.dev" : "peripherals://%s/%s.dev",
> > -                                          PeripheralTypeTranslator::BusTypeToString(scanResult.m_busType),
> > -                                          scanResult.m_strLocation.c_str(),
> > -                                          scanResult.m_iSequence);
> > +
> > +  if (scanResult.m_iSequence > 0)
> > +    m_strFileLocation = StringUtils::Format("peripherals://%s/%s_%d.dev",
> > +                                            PeripheralTypeTranslator::BusTypeToString(scanResult.m_busType),
> > +                                            scanResult.m_strLocation.c_str(),
> > +                                            scanResult.m_iSequence);
> > +  else
> > +    m_strFileLocation = StringUtils::Format("peripherals://%s/%s.dev",
> > +                                            PeripheralTypeTranslator::BusTypeToString(scanResult.m_busType),
> > +                                            scanResult.m_strLocation.c_str());
>
> i don't understand what's the problem. we have different prinft 
> formats with different parameters so we need to differ it in this case 
> and that's what we have done here.
>
> —
> Reply to this email directly or view it on GitHub 
> <https://github.com/xbmc/xbmc/pull/5408/files#r18204739>.
>