Fix heading markup in hot_spec.rst

The Resource Dependencies section in hot_spec.rst used a wrong
heading markup (inconsistent with previous sections' 2nd level
markups), so the heading did not appear in the HTML.

This patch fixes the markup.

Change-Id: Id10ca0246942b2b64ea6269413243379c3ae2158
Closes-Bug: #1295538
Display container ip not gateway IP

As described in the attribute schema of network_ip we want to show the
container ip and not the gateway ip.

Change-Id: I86a3c3476d04d437d7b6bb270d3178d0bc7e8136
Partial-Bug: #1296745
Add docker network_gateway attribute

We previously had it in network_ip attribute when that value should have
been the container ip. Add a new value called network_gateway giving
this information to the user.

Change-Id: I8ebfc576f4bbc470aa2d405e8b063932017904cc
Closes-Bug: 1296745
Update heat.conf.sample

A new version of python-keystoneclient has been released, with changes in
the options for the token auth middleware.

Change-Id: I04a725fac6dea8732533270828ad04f008142ab6
Fix using attributes in unittest

Resource generic_rsrc.ResourceWithComplexAttributes does not have needed
attributes in attribute schema and should be replaced on
generic_rsrc.ResWithComplexPropsAndAttrs.

Change-Id: I5ac60e95fe88bb7a2b9f4a2b612e55561afccd0d
Closes-Bug: #1298204
Order imports in alphabetical order (8/9)

This patch is one in a series to re-enable H306 style check rule
(imports are in alphabetical order).
It touches second half of tests (starting from test_n*).

Implements: blueprint reduce-flake8-ignored-rules (partial)
Change-Id: I5561d90a67eb5dc882200d432fda6b162011ac41
Fail if non-existent security group referenced

When using AWS::EC2::SecurityGroup resources with nova-network (not
Neutron), if a SourceSecurityGroupName was specified in a rule but the
name did not correspond to an extant security group it would be silently
ignored. This change ensures that any such error in the template will cause
creation of the security group to fail.

Closes-bug: #1291091

Change-Id: I9344451c83f4184ef46d4e9906b94abda08836df
Merge "Fix heading markup in hot_spec.rst"
Merge "Fix using attributes in unittest"
Merge "Fail if non-existent security group referenced"
Migrate invalid template version values

If a stack was created with a template that specified an invalid time,
a variety of operations cannot be done on the stack, resulting in a
general breakage of Heat.  This patch migrates any occurances of version
numbers that are invalid that were specified prior to the merging of this
patch.  This patch also handles invalid version fields where a non-date
is specified or an invalid date was specified.

Change-Id: I5387ffb84dba5160103b3cb02f3d1cc5f352ff29
Closes-bug: 1296859
OS::Nova::Server depend on subnets related to nets

Nova supports creating network interfaces by network ID however
if the network and the subnet are part of the same stack as this
server then a race occurs between the creation of the subnet and
the creation of the server. Likewise for delete the subnet cannot
be deleted until all ports are removed from it.

This change adds the same add_dependencies workaround to
OS::Nova::Server that OS::Neutron::Port and OS::Neutron::RouterGateway
have.

The confirmation that this change fixes the race will be confirmed
by tempest test NeutronResourcesTestJSON once
https://review.openstack.org/#/c/82393/ lands.

Change-Id: I626b976446cda709d96823c9de331eafc29d3c68
Closes-Bug: #1243992
Validate that resource type is a string

Raises a proper validation error when a non-string resource type is passed.

Change-Id: I1c84ee2bb1c7ff78802119e3321998b9d6487b2f
Closes-Bug: #1298548
Merge "Validate that resource type is a string"
Merge "Migrate invalid template version values"
Imported Translations from Transifex

Change-Id: I54d40a2c1d46c1f06e48034c52be5107bf80a62a
Merge "Display container ip not gateway IP"
Merge "Add docker network_gateway attribute"
Don't log exception for None timeout_mins

If a request contains a timeout_mins key but it is None (which is
now the case for all requests sent via python-heatclient), we log
an exception, but really we just want to ignore the value and
continue (as well as other "None" values, ie '0' which was the
previous default for no key)

So split the test for a key and conversion to int, and only log
the exception if there is an error doing the type conversion,
not if we get a value which implies ignoring/doing nothing.

Change-Id: I6b8d1f053b47fd4c22a5df636481a95bd046b1df
Closes-Bug: #1297759
Merge "Imported Translations from Transifex"