GIA-3216 - Fixed issue - Simple comment screen says 'comments are closed' even when they are open.
Add ids to comment article container template
Add id to standfirst
Add id for byline author
Merge pull request #295 from guardian/GIA-3216

GIA-3216 - Fixed issue - Simple comment screen says 'comments are closed...
Merge pull request #297 from guardian/gia-3166

GIA-3166 - Add ids to comment template
Add ids to video templates
AND-3136 - Fix positioning of Ads when a content embed is displayed. By introducing the setTimeOut with just a 50 MS delay prevents the getMpuPosCallback function from triggering to early and the correct add position with the iFrame content and height is computed passing the correct Ad position to window.GuardianJSInterface.mpuAdsPosition function which the native app uses to position the ads over the placeholders
AND-3136 - Fixed Issue with setTimeOut of 1 second - onload function for iFrame content being completely loaded triggering a callback would be ideal solution in case of slow connections as the getMpuPosCallback would only pass the Ad coordinates once the iFrame content has loaded, however I've not got this to work at this point and this bug is now on hold whilst a decision is made over Ad positioning, so I'm commiting this setTimeOut solution, now it only applies to Articles with an iFrame
Remove potential duplicating ids
AND-3136 - Remove console log message and changed user credentials from my old git hub account creds entered by accident to git config
AND-3136 - Commented out Console log messages and increased ad load delay on Articles with iFrames to 3 seconds to account for slower connections
AND-3136 - Commented out Console log messages and increased ad load delay on Articles with iFrames to 3 seconds to account for slower connections
AND-3136 - Changed if/else to ternary operator to make less verbose and changed onloadhandler function to CemelCase onloadHandler
Merge pull request #298 from guardian/AND-3136

AND 3136
AND-3134 - banner ads alignment incorrect - I've added getBannerPosCallback a duplicate of the original getMpuPosCallback function (this just changed for AND-3136). Also created getBannerPos a duplicate method of getMpuPos. getBannerPosCallback now passes x, y coords, width and height values to native function window.GuardianJSInterface.bannerAdsPosition(x, y, w, h)
AND-3134 - Also relates to native code change AND-3149. Added an id #banner_container to all templates that show a banner - the existing id I was using on the banner placeholder div (indicated by the dark grey box) #advert-banner-content was giving incorrect getBoundingClientRect top and scrollTop positions due to being a nested div I believe, so to get the correct position I used the parent wrapper div and gave this the unique ID #banner_container.
Merge pull request #299 from guardian/gia-3168

GIA-3168 - Add ids to video templates
Merge conflict resolution of style css
Merge fix