Update contact ui test

Left name field specific code as comments so it can be easialy put
back in place.
Fix contact create access check
Fix texts and labels

Match the labels and texts as they are checked in the ui test.
Redirect to contact view when saving an existing one.
Fix revision presave
Simplify contact type

Removeed attribute custom: With config entities distinguish between
UI generated and module generated does not make sense anymore.
Removeed attribute weight: was not persisted before and is nowhere used.
Removeed attribute locked: Replaced with status which is added by config entity.
Add Contact Type tests
Make contact type access check a access controller
Have contact types admin pages below admin/structure
Function deprecation

Remove deprecated functions if possible.
Mark them deprecated if left in place.
Move comment to correct line
Make primary field getters methods of the contact entity
Update hook_file_download_access