We could send back an empty 200 OK?  Part of me feels like we should send
back *something*, because it's a GET, but it's not a requirement and you're
right in that there's no additional data needed in the response at this
point in time.



On Thu, May 8, 2014 at 11:27 AM, David Ormsbee <notifications@github.com>wrote:

> In lms/djangoapps/api_manager/courses/views.py:
>
> > +        try:
> > +            course_descriptor = get_course(course_id)
> > +        except ValueError:
> > +            return Response({}, status=status.HTTP_404_NOT_FOUND)
> > +        store = modulestore()
> > +        try:
> > +            existing_module = store.get_instance(course_id, Location(module_id))
> > +        except InvalidLocationError:
> > +            return Response({}, status=status.HTTP_404_NOT_FOUND)
> > +        groups = ModuleGroupRelationship.objects.filter(course_id=course_id, module_id=module_id, group=group_id)
> > +        if len(groups):
> > +            response_data = {
> > +                'course_id': course_id,
> > +                'module_id': module_id,
> > +                'group_id': group_id,
> > +            }
>
> Wait, don't I need all this information to get here? It seems like the
> only response data we're sending back is the stuff the client already
> provides when making the request?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/edx-solutions/edx-platform/pull/42/files#r12434719>
> .
>



-- 
Matthew Drayer
Solutions Architect
edX | MIT
mattdrayer@edx.org