please add some doc for these two