2010-08-27  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. Skip a media test that fails on all mac test bots. Already notified Eric.

        * platform/mac/Skipped:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66190 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2010-08-27  Alejandro G. Castro  <alex@igalia.com>

        Unreviewed.

        Updated test resuls for gtk.

        * platform/gtk/editing/selection/iframe-expected.txt:
        * platform/gtk/fast/css/nested-rounded-corners-expected.txt:
        * platform/gtk/fast/events/standalone-image-drag-to-editable-expected.txt:
        * platform/gtk/fast/forms/placeholder-stripped-expected.txt:
        * platform/gtk/fast/frames/take-focus-from-iframe-expected.txt:
        * platform/gtk/fast/repaint/fixed-move-after-keyboard-scroll-expected.txt:
        * platform/gtk/fast/repaint/selection-gap-overflow-scroll-2-expected.txt:
        * platform/gtk/mathml/presentation/style-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66191 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2010-08-27  Alejandro G. Castro  <alex@igalia.com>

        Reviewed by Dan Bernstein.

        drawGDIGlyphs checks if the offset is empty incorrectly causing
        problems with the shadow
        https://bugs.webkit.org/show_bug.cgi?id=44619

        Removed the offset empty condition, now we just check if we have
        offset or blur.

        * platform/graphics/win/FontCGWin.cpp:
        (WebCore::drawGDIGlyphs):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66192 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2010-08-27  Yuzo Fujishima  <yuzo@google.com>

        Unreviewed Chromium test expectation change.

        * platform/chromium-linux/svg/custom/getscreenctm-in-scrollable-div-area-expected.checksum: Added.
        * platform/chromium-linux/svg/custom/getscreenctm-in-scrollable-div-area-expected.png: Added.
        * platform/chromium-linux/svg/custom/getscreenctm-in-scrollable-div-area-expected.txt: Added.
        * platform/chromium-linux/svg/custom/getscreenctm-in-scrollable-div-area-nested-expected.checksum: Added.
        * platform/chromium-linux/svg/custom/getscreenctm-in-scrollable-div-area-nested-expected.png: Added.
        * platform/chromium-linux/svg/custom/getscreenctm-in-scrollable-div-area-nested-expected.txt: Added.
        * platform/chromium-linux/svg/custom/getscreenctm-in-scrollable-svg-area-expected.checksum: Added.
        * platform/chromium-linux/svg/custom/getscreenctm-in-scrollable-svg-area-expected.png: Added.
        * platform/chromium-linux/svg/custom/getscreenctm-in-scrollable-svg-area-expected.txt: Added.
        * platform/chromium-win/svg/custom/getscreenctm-in-scrollable-div-area-expected.checksum: Added.
        * platform/chromium-win/svg/custom/getscreenctm-in-scrollable-div-area-expected.png: Added.
        * platform/chromium-win/svg/custom/getscreenctm-in-scrollable-div-area-expected.txt: Added.
        * platform/chromium-win/svg/custom/getscreenctm-in-scrollable-div-area-nested-expected.checksum: Added.
        * platform/chromium-win/svg/custom/getscreenctm-in-scrollable-div-area-nested-expected.png: Added.
        * platform/chromium-win/svg/custom/getscreenctm-in-scrollable-div-area-nested-expected.txt: Added.
        * platform/chromium-win/svg/custom/getscreenctm-in-scrollable-svg-area-expected.checksum: Added.
        * platform/chromium-win/svg/custom/getscreenctm-in-scrollable-svg-area-expected.png: Added.
        * platform/chromium-win/svg/custom/getscreenctm-in-scrollable-svg-area-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66193 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2010-08-27  Kent Tamura  <tkent@chromium.org>

        Reviewed by Pavel Feldman.

        [DRT/Chromium] Fix inspector test failures
        https://bugs.webkit.org/show_bug.cgi?id=44748

        * platform/chromium/drt_expectations.txt:
         Update expectations for the DRT change.
2010-08-27  Kent Tamura  <tkent@chromium.org>

        Reviewed by Pavel Feldman.

        [DRT/Chromium] Fix inspector test failures
        https://bugs.webkit.org/show_bug.cgi?id=44748

        * DEPS: Update Chromium revision to 57605 to have a webkit_support change.
2010-08-27  Kent Tamura  <tkent@chromium.org>

        Reviewed by Pavel Feldman.

        [DRT/Chromium] Fix inspector test failures
        https://bugs.webkit.org/show_bug.cgi?id=44748

        * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
        (DRTDevToolsAgent::createClientMessageLoop):
          Returns a valid WebKitClientMessageLoop instance
        * DumpRenderTree/chromium/DRTDevToolsAgent.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66194 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2010-08-27  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Nikolas Zimmermann.

        r66141 caused fast/forms/select-style.html to fail on mac:
        https://bugs.webkit.org/show_bug.cgi?id=44737

        Handle the fact that a CSSImageValue may have a value of CSSValueNone,
        in which case we should not return a pending image.

        * css/CSSImageValue.cpp:
        (WebCore::CSSImageValue::cachedOrPendingImage):
        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::cachedOrPendingFromValue):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66195 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2010-08-27  Yuzo Fujishima  <yuzo@google.com>

        Unreviewed Chromium test expectation change.

        * platform/chromium-linux/svg/dom/path-pointAtLength-expected.txt: Added.
        * platform/chromium-win/svg/dom/path-pointAtLength-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66196 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2010-08-27  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r66188.
        http://trac.webkit.org/changeset/66188
        https://bugs.webkit.org/show_bug.cgi?id=44756

        "Graphic libraries handle segement length differently. Fixing
        one platform might break another one. Rolling out this patch
        and think about another solution to get getPointAtLength"
        (Requested by krit on #webkit).

        * svg/dom/path-pointAtLength-expected.txt: Removed.
        * svg/dom/path-pointAtLength.html: Removed.
        * svg/dom/script-tests/path-pointAtLength.js: Removed.
2010-08-27  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r66188.
        http://trac.webkit.org/changeset/66188
        https://bugs.webkit.org/show_bug.cgi?id=44756

        "Graphic libraries handle segement length differently. Fixing
        one platform might break another one. Rolling out this patch
        and think about another solution to get getPointAtLength"
        (Requested by krit on #webkit).

        * platform/graphics/PathTraversalState.cpp:
        (WebCore::PathTraversalState::closeSubpath):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66197 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2010-08-27  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        REGRESSION: Crash occurs at objc_msgSend when closing a window that is displaying the web inspector
        https://bugs.webkit.org/show_bug.cgi?id=44230

        * inspector/Inspector.idl:
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::inspectedPageDestroyed):
        (WebCore::InspectorController::close):
        * inspector/InspectorFrontendClient.h:
        * inspector/InspectorFrontendHost.cpp:
        (WebCore::InspectorFrontendHost::disconnectFromBackend): don't try to notify InspectorController
        that frontend closes if InspectorController triggered the action.
        * inspector/InspectorFrontendHost.h:
        * inspector/InspectorFrontendHost.idl:
        * inspector/front-end/InspectorFrontendHostStub.js:
        (.WebInspector.InspectorFrontendHostStub.prototype.disconnectFromBackend):
        * inspector/front-end/inspector.js:
        (WebInspector.disconnectFromBackend):
2010-08-27  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        REGRESSION: Crash occurs at objc_msgSend when closing a window that is displaying the web inspector
        https://bugs.webkit.org/show_bug.cgi?id=44230

        * src/InspectorFrontendClientImpl.cpp:
        (WebKit::InspectorFrontendClientImpl::disconnectFromBackend):
        * src/InspectorFrontendClientImpl.h:
2010-08-27  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        REGRESSION: Crash occurs at objc_msgSend when closing a window that is displaying the web inspector
        https://bugs.webkit.org/show_bug.cgi?id=44230

        * WebCoreSupport/InspectorClientGtk.cpp:
        (WebKit::notifyWebViewDestroyed):
        (WebKit::InspectorFrontendClient::destroyInspectorWindow):
        (WebKit::InspectorFrontendClient::closeWindow):
        (WebKit::InspectorFrontendClient::disconnectFromBackend):
        * WebCoreSupport/InspectorClientGtk.h:
2010-08-27  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        REGRESSION: Crash occurs at objc_msgSend when closing a window that is displaying the web inspector
        https://bugs.webkit.org/show_bug.cgi?id=44230

        * WebCoreSupport/WebInspectorClient.h:
        * WebCoreSupport/WebInspectorClient.mm:
        (WebInspectorFrontendClient::closeWindow):
        (WebInspectorFrontendClient::disconnectFromBackend):
        (-[WebInspectorWindowController windowShouldClose:]):
        (-[WebInspectorWindowController destroyInspectorView:]):
2010-08-27  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        REGRESSION: Crash occurs at objc_msgSend when closing a window that is displaying the web inspector
        https://bugs.webkit.org/show_bug.cgi?id=44230

        * WebCoreSupport/InspectorClientQt.cpp:
        (WebCore::InspectorClientQt::inspectorDestroyed):
        (WebCore::InspectorClientQt::openInspectorFrontend):
        (WebCore::InspectorClientQt::releaseFrontendPage):
        (WebCore::InspectorFrontendClientQt::closeWindow):
        (WebCore::InspectorFrontendClientQt::disconnectFromBackend):
        (WebCore::InspectorFrontendClientQt::destroyInspectorView):
        (WebCore::InspectorFrontendClientQt::inspectorClientDestroyed):
        * WebCoreSupport/InspectorClientQt.h:
2010-08-27  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        REGRESSION: Crash occurs at objc_msgSend when closing a window that is displaying the web inspector
        https://bugs.webkit.org/show_bug.cgi?id=44230

        * WebCoreSupport/WebInspectorClient.cpp:
        (WebInspectorFrontendClient::~WebInspectorFrontendClient):
        (WebInspectorFrontendClient::closeWindow):
        (WebInspectorFrontendClient::disconnectFromBackend):
        (WebInspectorFrontendClient::closeWindowWithoutNotifications):
        (WebInspectorFrontendClient::destroyInspectorView):
        * WebCoreSupport/WebInspectorClient.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66198 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2010-08-27  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. Also skip media/video-source-error.html on Leopard, and media/video-zoom-controls.html on SnowLeopard.
        It's a pity that numerous of the media tests are skipped since a longer time on these platforms.

        * platform/mac-leopard/Skipped:
        * platform/mac-snowleopard/Skipped:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66199 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2010-08-27  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. Remove trailing whitespace after test name, no need to duplicate the same test in mac/Skipped and mac-leopard/Skipped, oops.

        * platform/mac-leopard/Skipped:
        * platform/mac/Skipped:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66200 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2010-08-27  Steve Block  <steveblock@google.com>

        Reviewed by Darin Adler.

        js-test-post.js is not robust for asynchronous tests
        https://bugs.webkit.org/show_bug.cgi?id=44642

        This patch moves finishJSTest() to js-test-pre.js to make it available for when an
        asynchronous test completes before js-test-post.js has been parsed, and updates
        js-test-post.js to handle this case.

        * fast/dom/Window/window-property-descriptors-expected.txt:
        * fast/js/resources/js-test-post.js:
        * fast/js/resources/js-test-pre.js:
        (finishJSTest):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66201 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2010-08-27  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Tor Arne Vestbø.

        Fix a couple of typos in comment.

        * bytecode/CodeBlock.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66202 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2010-08-27  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r66196.
        http://trac.webkit.org/changeset/66196
        https://bugs.webkit.org/show_bug.cgi?id=44758

        Corresponding test has been rolled back (Requested by yuzo on
        #webkit).

        * platform/chromium-linux/svg/dom/path-pointAtLength-expected.txt: Removed.
        * platform/chromium-win/svg/dom/path-pointAtLength-expected.txt: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66203 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2010-08-27  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        SVG Filter with wrong results on repaint for non-CG platforms
        https://bugs.webkit.org/show_bug.cgi?id=44706
        
        The result of SVG Filter is transformed to linearRGB on every repaint. 
        Transform the result just once, right after creating it.

        Test: svg/repaint/filter-repaint.svg

        * rendering/RenderSVGResourceFilter.cpp:
        (WebCore::RenderSVGResourceFilter::postApplyResource):
2010-08-27  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        SVG Filter with wrong results on repaint for non-CG platforms
        https://bugs.webkit.org/show_bug.cgi?id=44706
        
        Test that repainting a Filter does not change the result.

        * platform/mac/svg/repaint: Added.
        * platform/mac/svg/repaint/filter-repaint-expected.checksum: Added.
        * platform/mac/svg/repaint/filter-repaint-expected.png: Added.
        * platform/mac/svg/repaint/filter-repaint-expected.txt: Added.
        * svg/repaint: Added.
        * svg/repaint/filter-repaint.svg: Added.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66204 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2010-08-27  Chao-ying Fu  <fu@mips.com>

        Reviewed by Oliver Hunt.

        Byte alignment issue on MIPS
        https://bugs.webkit.org/show_bug.cgi?id=29415

        MIPS accesses one byte at a time for now to avoid the help from the
        kernel to fix unaligned accesses.

        * wtf/text/AtomicString.cpp:
        (WebCore::equal):
        * wtf/text/StringHash.h:
        (WebCore::StringHash::equal):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66205 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2010-08-27  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. Turn leopard bot green again (skip more media tests :/)

        * platform/mac-leopard/Skipped:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66206 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Unreviewed. Add myself to the committers list.

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66207 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2010-08-27  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        getPointAtLength returns incorrect values for paths closed with the closepath command
        https://bugs.webkit.org/show_bug.cgi?id=44197
        
        The closepath segment was traversed by the wrong direction. Swap starting point and
        end point for closeSubpath.

        Test: svg/dom/path-pointAtLength.html

        * platform/graphics/PathTraversalState.cpp:
        (WebCore::PathTraversalState::closeSubpath):
2010-08-27  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        getPointAtLength returns incorrect values for paths closed with the closepath command
        https://bugs.webkit.org/show_bug.cgi?id=44197
        
        Test that path gives back the correct point on a given length for the closepath segment.

        * svg/dom/path-pointAtLength-expected.txt: Added.
        * svg/dom/path-pointAtLength.html: Added.
        * svg/dom/script-tests/path-pointAtLength.js: Added.
        (pointAtLengthOfPath):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66208 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2010-08-27  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. Skip another test that is problematic, on leopard & sl bots.

        * platform/mac/Skipped:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66209 268f45cc-cd09-0410-ab3c-d52691b4dbfc