Cc pdlogs 61

Updated after review comments for the ENT feature.  
Modified the messages to capitalize acronyms.  
Removed unnecessary whitespace.  
Added full stop to end of each part of the message.  
Actions are numbered if there is more than one action.  This separates the individual actions.
Separated the log definitions with a blank line to make them more readable.  
Ran astyle (according to the coding standards) against sprout_ent_definitions.h.
Fixed header file inconsistencies.
The review comment had: "A lot of the logs still say 'report issue to support' or something similar. This just isn't suitable for Project Clearwater."
The language was kept the same as this is what is done for the SNMP alarm definitions.  The associated documentation should identify the Metaswitch support team for ClearwaterCore and the Clearwater mailing list for Clearwater.
Removed signalnames.cpp.  The signal call name is now obtained from the strsignal call.
Not an issue.  I first started programming in 1975.  It was always a knee-jerk reaction to avoid entanglements with other software if it can be avoided.  If you say boost is a good approach I accept that.  I see the advantage.  It's just when I see that there are additional required configurations, then I start to question the approach.  I will pursue the additional configuration(s) with Doug this morning.  I have to finish this today.  Jim is going to pull me off to do CC v6 test cases until the end of January.


Sent from my iPad

On Dec 19, 2014, at 5:07 AM, Andy Caldwell <notifications@github.com<mailto:notifications@github.com>> wrote:


In sprout/sprout_base.mk<https://github.com/Metaswitch/sprout/pull/895#discussion-diff-22099597>:

> @@ -114,7 +114,8 @@ LDFLAGS += -lmemcached \
>             -levent \
>             -levent_pthreads \
>             -lcurl \
> -           -lsas
> +           -lsas \
> +           -lboost_filesystem


Surely adding extra dependencies can't be that hard right? If it is, then surely that's going to preclude you taking future releases of Project Clearwater if we add third party dependencies?

You could go the way you're proposing, but it probably won't be portable (to other OSs or potentially to other file-systems) and would require re-inventing the wheel that boost already provides. If you do go that way, you'll want to add this path parsing code to cpp-common so it can be easily shared between the repositories.

—
Reply to this email directly or view it on GitHub<https://github.com/Metaswitch/sprout/pull/895/files#r22099597>.