some testing and minor refactoring in one of our hairier methods in preparation for future changes
cr feedback: comment about the duplicate routes, remove random cryptic comment, more route testing
Merge pull request #470 from code-dot-org/activities-milestone-testing

some testing and minor refactoring in ActivitiesController#milestone in preparation for future changes