work on productscontroller