Update recipes to be rubocop compliant

- Adjust .rubocop.yml to include recipes/**
- Complete rubocop compliancy for recipes/*.rb

Change-Id: Id5b5ac26f74046085e3f07d1696189061a03ee2e
Addresses: blueprint rubocop-for-network
Remove unneeded and redundant rhel setup scripts

3 scripts called in rhel/centos/fedora case
- neutron-dhcp-setup
- neutron-l3-setup
- neturon-node-setup (openvswitch)

They set config options that are already handled, for example:
messaging - rpc_backend and qpid_hostname.
keystone - auth_url, admin_username, admin_password, admin_tenant_name.
Testing confirmed no differences in etc/neutron config tree.

Addresses: blueprint centos-rhel-for-network

Change-Id: I56f8482d95908d41e0b33552017166a4e1105177
Merge "Remove unneeded and redundant rhel setup scripts"
update neutron policy.json

Fixes: bug: 1274866

some rules in policy.json are deprecated in Havana.  This updates to the
latest set of compatible rules and stops deprecation warnings.

Change-Id: Ie0a3f9b890c1636ee6efa65dee612621a8ddb2d9
Upgrade/Update rubocop

Now that almost all of the rubocop blueprints have been completed, make
one final pass through all of the cookbooks ensuring they're all in
sync with each other.

- Upgrade rubocop to 0.18.1
- Fix violations caused by 0.18.1 upgrade
- Add Includes for non-existent folders to Includes so they
  automatically cover future additions

Change-Id: Ib3220a0ab8281bc0eafaf9898c233d90490cfde6
Implements: blueprint lint-and-unit-testing-for-havana
Explicitly set rpc_backend to kombu when using rabbitmq

On centos systems, /usr/share/neutron/neutron-dist.conf sets:

rpc_backend = neutron.openstack.common.rpc.impl_qpid

In order to set this correctly when using rabbit, we need to explicitly
set it in neutron.conf to override the setting in the dist file

- explicitly set rpc_backend when rabbitmq used
- add wrap around commented out zmq section

Change-Id: Ifea0ecc7ec50f7a0938b1bdd19f9da73dcb42c1e
Implements: blueprint centos-rhel-for-network
Merge "Upgrade/Update rubocop"
Merge "Explicitly set rpc_backend to kombu when using rabbitmq"
change tests to use SLES11SP3 instead of openSUSE 12.3

Change-Id: I9777c781cb85157c10110898a1b0563b6d259168
Explicitly set auth_strategy

On centos systems, /usr/share/neutron/neutron-dist.conf sets:

auth_strategy = noop

In order to set this correctly back to the upstream default of keystone we
need to explicitly set it in neutron.conf to override the
setting in the dist file

Change-Id: I9b5d7b629a97e6f8ec758fbea759d1ddf3fb039a
Implements: blueprint centos-rhel-for-network
Honor package override platform options

Following suit with the other cookbooks, this change makes
openstack-network::server and openstack-network::openvswitch take care
of package overrides coming from the platform options.

The tests for openvswitch have been fleshed out since they were lacking
in some regards.  Analogous work for the other parts (linuxbridge, ...)
still has to be done.

Change-Id: I3022c29add80f20adf73bb2c9eb3226264918ff0
Merge "change tests to use SLES11SP3 instead of openSUSE 12.3"
Merge "Honor package override platform options"
Merge "Explicitly set auth_strategy"