On Wed, Jan 22, 2014 at 1:56 AM, José Valim <notifications@github.com>wrote:

> In lib/elixir/lib/exception.ex:
>
> > @@ -326,21 +331,48 @@ defmodule Exception do
> >        "nil.bar()"
> >
> >    """
> > +  def format_mfa(module, nil, arity),
> > +  do: format_mfa(module, "nil", arity)
> > +
> > +  def format_mfa(module, fun, arity) when is_atom(fun),
> > +  do: format_mfa(module, to_string(fun), arity)
> > +
> > +  def format_mfa(module, fun, arity) when not(is_binary(fun)),
>
> I don't think we should accept non binaries through this function public
> interface. The public interface should only accept atoms and then we need
> to convert it to binaries and process it internally.
>

Does it need to be public at all? It seems a little low-level to be exposed.