[RFC] Merge FifoCommandRunnable into Decode

No idea if this change is desirable.
It refers to the fact we read long streams of NOP one at a time instead of
jumping over all of them at once.


On Mon, Jul 7, 2014 at 4:41 PM, Tony Wasserka <notifications@github.com>
wrote:

> In Source/Core/VideoCommon/OpcodeDecoding.cpp:
>
> >  	switch (cmd_byte)
> >  	{
> > -	case GX_NOP: // Hm, this means that we scan over nop streams pretty slowly...
> > -		command_size = 1;
> > -		cycleTime = 6;
> > -		break;
> > -	case GX_CMD_INVL_VC: // Invalidate Vertex Cache - no parameters
> > -		command_size = 1;
> > -		cycleTime = 6;
> > -		break;
> > -	case GX_CMD_UNKNOWN_METRICS: // zelda 4 swords calls it and checks the metrics registers after that
> > -		command_size = 1;
> > +	case GX_NOP:
> > +		DataReadU8();
> > +		// Hm, this means that we scan over nop streams pretty slowly...
>
> The comment dates back to before cycleTime existed ;)
>
> tbh I guess the comment can be removed altogether, since I don't think
> anyone but its author actually understands what it was referring to
> specifically.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/dolphin-emu/dolphin/pull/572/files#r14599520>.
>



-- 
Pierre "delroth" Bourdon <delroth@gmail.com>
Software Engineer @ Zürich, Switzerland
http://code.delroth.net/