Remove unused variables.
MXM: fix warning

reviewed by Yossi

cmr=v1.8.2:reviewer=ompi-rm1.8
OSHMEM: use bulk connect/disconnect API

fixed by Yossi, reviewed by MikeD

cmr=v1.8.2:reviewer=ompi-rm1.8
update
atomic_impl.h: fix trivial typos in comments

cmr=v1.8.2:ticket=#4664
Potentially temporarily change the barrier in the ORTE DPM component
to be based on grpcomm (i.e., an out-of-band based barrier) rather
than the simplistic PML-based barrier that it currently uses.

This is pending a larger discussion with Nathan and George, but it
will allow the usnic BTL to stop assert()-failing in light of the
recent del_procs() change.
usnic: re-order teardown sequence now that del_procs() is actually called

Now that the infrastructure is calling BTL del_procs() before the BTL
finalize(), the usnic BTL had to re-order some of its teardown
sequence to avoid assert() failing.

This is part of a larger conversation involving #4669.  Since
MPI_FINALIZE and MPI_COMM_DISCONNECT currently use an
oob/grpcomm-based barrier, the usnic BTL can ''absolutely know'' that
these endpoints and procs will no longer be used.  If the ORTE DPM
goes back to a PML-based barrier, the usnic BTL will need to grow more
complex teardown semantics (a la TCP socket FIN/ACK/FIN_WAIT states).

Refs #4669
Gah; we need to have a unique barrier ID for the ompi_rte_barrier()
operation.  Ralph will fix shortly.

For the time being, put back the original code...

Refs #4669
Turns out that valgrind has issues with strings that don't fall on nice 4-byte alignments with some optimized builds. So make the default security credential a nice 7-characters (so we get 8-bytes with the NULL terminator) to make valgrind shut up.

Thanks to Walter Spector for reporting this.

cmr=v1.8.2:reviewer=jsquyres:subject=align the default sec credential
Fix deallocation error in mca_common_sm_rml_info_bcast()

buffer is sent (num_local_procs-1) time, so it should be
OBJ_RETAIN'ed (num_local_procs-2) time

cmr=v1.8.2:reviewer=rhc
Update git/hg ignore files
Release the buffer in all error cases and add small code cleanups.
Remove a warning on p.
And correctly handle the reference count from OBJ_NEW in the error
path (thanks Gilles for noticing).
OSHMEM: fix - use real mkey for atomics for rc/dc

fixed by Roman, reviewed by Vasily

cmr=v1.8.2:reviewer=ompi-rm1.8
Remove a double const warning.
OSHMEM: fix compiler warnings

fixed by Roman, reviewed by Miked

cmr=v1.8.2:reviewer=ompi-rm1.8
OSHMEM: add compat to prev mxm version

fixed by ROman, reviewed by MikeD

Refs: #4672
plm/alps: better workaround for the noisy cray pmi implementation

This commit is a slightly better workaround to prevent mesages of
the form:
[unset]:_pmi_alps_get_apid:alps_app_lli_put_request failed
[unset]:_pmi_alps_get_appLayout:pmi_alps_get_apid returned with error: Bad file descriptor

It works by completely disabling PMI in the application process when using
mpirun. This should not be an issue for any apps.

cmr=v1.8.2:reviewer=rhc
correctly allocate cart in mca_topo_base_cart_sub(...)

since r31716 mca_topo_base_comm_cart_2_2_0_t is an object
and must be allocated/freed with OBJ_NEW/OBJ_RELEASE.

this fixes topology/cart_sub_zero from the ibm test suite.

v1.8 does not use objects, so no cmr for this branch
do not incrementing/decrementing the opal_progress_event_state.

Per Ralph :
"I noticed that we are incrementing and decrementing the opal_progress_event state.
However, this no longer has any impact whatsoever on the RML as that is running in
the independent ORTE event thread. So all this actually does is impact the MPI layer
by adding an unnecessary overhead."

Thanks Ralph for pointing this :-)

cmr=v1.8.2:reviewer=rhc:ticket=4671