2010-09-24  Nate Chapin  <japhet@chromium.org>

        Unreviewed, chromium expectations update.

        http/tests/navigation/ping-* are passing now
        that they have had their LayoutTestController patch.

        * platform/chromium/test_expectations.txt:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68263 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Add PluginProcess class
https://bugs.webkit.org/show_bug.cgi?id=46476

Reviewed by Sam Weinig.

* PluginProcess/PluginProcess.cpp: Added.
* PluginProcess/PluginProcess.h: Added.
Add stubbed out PluginProcess class.

* PluginProcess/mac/PluginProcessMainMac.mm:
(WebKit::PluginProcessMain):
Initialize the plug-in process.

* WebKit2.xcodeproj/project.pbxproj:
Add files.

* WebProcess/Plugins/PluginProcessConnection.h:
Add a comment about which connection this is.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68264 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2010-09-24  Tony Chang  <tony@chromium.org>

        Reviewed by Kent Tamura.

        [chromium] Remove a bad baseline and clean up a comment
        https://bugs.webkit.org/show_bug.cgi?id=46446

        * platform/chromium-linux/svg/filters/filterRes-expected.checksum: Removed.
        * platform/chromium-linux/svg/filters/filterRes-expected.png: Removed.
        * platform/chromium-win/svg/filters/filterRes-expected.checksum: Removed.
        * platform/chromium-win/svg/filters/filterRes-expected.png: Removed.
        * platform/chromium-win/svg/filters/filterRes-expected.txt: Removed.
        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68265 268f45cc-cd09-0410-ab3c-d52691b4dbfc
        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=46380
        REGRESSION: Crash when downloading a file

        Downloading cannot be tested in DRT.

        * Misc/WebNSFileManagerExtras.m: (-[NSFileManager _webkit_setMetadataURL:referrer:atPath:]):
        Don't copy null strings.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68266 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Add WebProcessConnection class
https://bugs.webkit.org/show_bug.cgi?id=46478

Reviewed by Sam Weinig.

* PluginProcess/WebProcessConnection.cpp: Added.
* PluginProcess/WebProcessConnection.h: Added.
Add stubbed out WebProcessConnection class.

* WebKit2.xcodeproj/project.pbxproj:
Add files.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68267 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2010-09-24  Mihai Parparita  <mihaip@chromium.org>

        Reviewed by Tony Chang.

        NRWT doesn't respect config set with set-webkit-configuration
        https://bugs.webkit.org/show_bug.cgi?id=46278

        Use Port.default_configuration() instead of hardcoding Release in
        ChromiumPort configuration initialization, so that we still inherit the
        configuration set by set-webkit-configuration.

        * Scripts/webkitpy/layout_tests/port/chromium.py:
        * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68268 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Expose a whole DrawingAreaInfo instead of its constituent parts from DrawingAreaBase

This is just a step toward cleaning up how drawing areas are
encoded/ecoded.

Fixes <http://webkit.org/b/46468> DrawingAreaInfo should be used in
more places

Reviewed by Anders Carlsson.

* Shared/DrawingAreaBase.cpp:
(WebKit::DrawingAreaBase::encode): Changed to use info().

* Shared/DrawingAreaBase.h:
(WebKit::DrawingAreaBase::info): Added. Replaces type() and id().
(WebKit::DrawingAreaBase::DrawingAreaBase): Changed to store a
DrawingAreaInfo instead of storing its constituent parts.

* UIProcess/API/mac/WKView.mm:
* UIProcess/ChunkedUpdateDrawingAreaProxy.cpp:
* UIProcess/LayerBackedDrawingAreaProxy.cpp:
* WebProcess/WebPage/ChunkedUpdateDrawingArea.cpp:
* WebProcess/WebPage/LayerBackedDrawingArea.cpp:
* WebProcess/WebPage/WebPage.cpp:
Updated to use info().

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68269 268f45cc-cd09-0410-ab3c-d52691b4dbfc
https://bugs.webkit.org/show_bug.cgi?id=46474
        
Reviewed by Sam Weinig.

Patch computeWidthUsing to be block-flow-aware.  Rename the WidthType enum to LogicalWidthType.  Make computeLogicalWidthUsing
query the style for logical width properties instead of width properties.
        
fast/css/logical-property-resolution.html now fails and gives bad results.  This is expected.  It will become correct
again as more layout code gets patched.

WebCore: 

* rendering/RenderBox.cpp:
(WebCore::RenderBox::computeLogicalWidth):
(WebCore::RenderBox::computeLogicalWidthUsing):
(WebCore::RenderBox::sizesToIntrinsicWidth):
* rendering/RenderBox.h:

LayoutTests: 

* fast/css/logical-property-resolution-expected.txt:
* fast/css/logical-property-resolution.html:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68270 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Stop pretending that we know how to encode a DrawingArea and just encode the DrawingAreaInfo directly

DrawingAreaBase and friends were trying to hide the fact that they
were just encoding/decoding a DrawingAreaInfo behind the scenes, but
everyone knew what was going on and it was getting embarassing.

Fixes <http://webkit.org/b/46469> Code to encode/decode a
DrawingAreaInfo is confusing

Reviewed by Anders Carlsson.

* Shared/DrawingAreaBase.cpp: Removed.
* Shared/DrawingAreaBase.h: Removed encode/decode.
* UIProcess/ChunkedUpdateDrawingAreaProxy.h: Removed encode override.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::initializeWebPage):
(WebKit::WebPageProxy::reinitializeWebPage):
(WebKit::WebPageProxy::didReceiveSyncMessage):
Changed to encode the DrawingAreaInfo directly.

* WebKit2.pro:
* WebKit2.xcodeproj/project.pbxproj:
* win/WebKit2.vcproj:
Removed DrawingAreaBase.cpp.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68271 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Add WebPageCreationParameters

This struct is used in any messages that end up creating a WebPage.
Using a struct instead of individual parameters will make it easier to
add platform-specific data, such as an HWND on Windows.

Fixes <http://webkit.org/b/46470> Pass parameters for creating a
WebPage in a single struct

Reviewed by Anders Carlsson.

* Shared/WebPageCreationParameters.cpp: Added.
(WebKit::WebPageCreationParameters::encode):
(WebKit::WebPageCreationParameters::decode):
Simple encode/decode functions.

* Shared/WebPageCreationParameters.h: Added.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::initializeWebPage):
(WebKit::WebPageProxy::reinitializeWebPage):
(WebKit::WebPageProxy::didReceiveSyncMessage):
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::createWindow):
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::createWebPage):
(WebKit::WebProcess::didReceiveMessage):
* WebProcess/WebProcess.h:
Changed to use WebPageCreationParameters instead of passing the
values individually.

* WebKit2.pro:
* WebKit2.xcodeproj/project.pbxproj:
* win/WebKit2.vcproj:
Added WebPageCreationParameters.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68272 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2010-09-24  Zhenyao Mo  <zmo@google.com>

        Unreviewed.

        Remove outdated WebGL linux entries from chromium/drt_expectations.txt.

        * platform/chromium/drt_expectations.txt:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68273 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Add WebKit2 C API for setting/getting frame flattening and plugin settings.
http://webkit.org/b/46477

Reviewed by Sam Weinig.

NOTE: The plugin setting was partly done but there was no C API.

* Shared/WebPreferencesStore.cpp:
(WebKit::WebPreferencesStore::WebPreferencesStore):
(WebKit::WebPreferencesStore::encode):
(WebKit::WebPreferencesStore::decode):
* Shared/WebPreferencesStore.h:
* UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetFrameFlatteningEnabled):
(WKPreferencesGetFrameFlatteningEnabled):
(WKPreferencesSetPluginsEnabled):
(WKPreferencesGetPluginsEnabled):
* UIProcess/API/C/WKPreferences.h:
* UIProcess/WebPreferences.cpp:
(WebKit::WebPreferences::setFrameFlatteningEnabled):
(WebKit::WebPreferences::frameFlatteningEnabled):
(WebKit::WebPreferences::setPluginsEnabled):
(WebKit::WebPreferences::pluginsEnabled):
* UIProcess/WebPreferences.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
(WebKit::WebPage::preferencesDidChange):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68274 268f45cc-cd09-0410-ab3c-d52691b4dbfc
DOMWindow::revokeBlobURL erroneously uses ParsedURLString.
https://bugs.webkit.org/show_bug.cgi?id=46434

Reviewed by Alexey Proskuryakov.

WebCore:

Test: fast/files/revoke-blob-url.html

* page/DOMWindow.cpp:
(WebCore::DOMWindow::revokeBlobURL):

LayoutTests:

Add a test. Also update Skipped files for those not-supported platforms.

* fast/files/revoke-blob-url-expected.txt: Added.
* fast/files/revoke-blob-url.html: Added.
* platform/gtk/Skipped:
* platform/mac-wk2/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68275 268f45cc-cd09-0410-ab3c-d52691b4dbfc
https://bugs.webkit.org/show_bug.cgi?id=46482, rename the various prefWidth functions to use
preferredLogicalWidth.

Reviewed by Simon Fraser.

* rendering/AutoTableLayout.cpp:
(WebCore::AutoTableLayout::recalcColumn):
(WebCore::AutoTableLayout::computePreferredLogicalWidths):
(WebCore::AutoTableLayout::calcEffectiveWidth):
* rendering/AutoTableLayout.h:
* rendering/FixedTableLayout.cpp:
(WebCore::FixedTableLayout::calcWidthArray):
(WebCore::FixedTableLayout::computePreferredLogicalWidths):
* rendering/FixedTableLayout.h:
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::layoutBlockChildren):
(WebCore::RenderBlock::layoutPositionedObjects):
(WebCore::RenderBlock::getClearDelta):
(WebCore::RenderBlock::computePreferredLogicalWidths):
(WebCore::RenderBlock::computeInlinePreferredLogicalWidths):
(WebCore::RenderBlock::computeBlockPreferredLogicalWidths):
* rendering/RenderBlock.h:
* rendering/RenderBlockLineLayout.cpp:
(WebCore::dirtyLineBoxesForRenderer):
(WebCore::RenderBlock::layoutInlineChildren):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::RenderBox):
(WebCore::RenderBox::minPreferredLogicalWidth):
(WebCore::RenderBox::maxPreferredLogicalWidth):
(WebCore::RenderBox::computeLogicalWidth):
(WebCore::RenderBox::computeLogicalWidthUsing):
(WebCore::RenderBox::computePositionedLogicalWidth):
(WebCore::RenderBox::computePositionedLogicalWidthUsing):
* rendering/RenderBox.h:
(WebCore::RenderBox::computePreferredLogicalWidths):
* rendering/RenderCounter.cpp:
(WebCore::RenderCounter::computePreferredLogicalWidths):
* rendering/RenderCounter.h:
* rendering/RenderDataGrid.cpp:
(WebCore::RenderDataGrid::computePreferredLogicalWidths):
* rendering/RenderDataGrid.h:
* rendering/RenderFieldset.cpp:
(WebCore::RenderFieldset::computePreferredLogicalWidths):
* rendering/RenderFieldset.h:
* rendering/RenderFileUploadControl.cpp:
(WebCore::RenderFileUploadControl::computePreferredLogicalWidths):
* rendering/RenderFileUploadControl.h:
* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::calcHorizontalPrefWidths):
(WebCore::RenderFlexibleBox::calcVerticalPrefWidths):
(WebCore::RenderFlexibleBox::computePreferredLogicalWidths):
(WebCore::RenderFlexibleBox::allowedChildFlex):
* rendering/RenderFlexibleBox.h:
* rendering/RenderFrameBase.cpp:
(WebCore::RenderFrameBase::layoutWithFlattening):
* rendering/RenderHTMLCanvas.cpp:
(WebCore::RenderHTMLCanvas::canvasSizeChanged):
* rendering/RenderImage.cpp:
(WebCore::RenderImage::imageChanged):
* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::computePreferredLogicalWidths):
* rendering/RenderListBox.h:
* rendering/RenderListItem.cpp:
(WebCore::RenderListItem::updateMarkerLocation):
(WebCore::RenderListItem::computePreferredLogicalWidths):
* rendering/RenderListItem.h:
* rendering/RenderListMarker.cpp:
(WebCore::RenderListMarker::layout):
(WebCore::RenderListMarker::computePreferredLogicalWidths):
(WebCore::RenderListMarker::updateMargins):
* rendering/RenderListMarker.h:
* rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::computePreferredLogicalWidths):
* rendering/RenderMenuList.h:
* rendering/RenderObject.cpp:
(WebCore::RenderObject::RenderObject):
(WebCore::RenderObject::setPreferredLogicalWidthsDirty):
(WebCore::RenderObject::invalidateContainerPreferredLogicalWidths):
* rendering/RenderObject.h:
(WebCore::RenderObject::preferredLogicalWidthsDirty):
(WebCore::RenderObject::setNeedsLayoutAndPrefWidthsRecalc):
(WebCore::RenderObject::minPreferredLogicalWidth):
(WebCore::RenderObject::maxPreferredLogicalWidth):
* rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::computePreferredLogicalWidths):
* rendering/RenderReplaced.h:
* rendering/RenderReplica.cpp:
(WebCore::RenderReplica::computePreferredLogicalWidths):
* rendering/RenderReplica.h:
* rendering/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::computePreferredLogicalWidths):
* rendering/RenderSVGRoot.h:
* rendering/RenderScrollbarPart.cpp:
(WebCore::RenderScrollbarPart::computePreferredLogicalWidths):
* rendering/RenderScrollbarPart.h:
* rendering/RenderSlider.cpp:
(WebCore::RenderSlider::computePreferredLogicalWidths):
* rendering/RenderSlider.h:
* rendering/RenderTable.cpp:
(WebCore::RenderTable::computeLogicalWidth):
(WebCore::RenderTable::computePreferredLogicalWidths):
* rendering/RenderTable.h:
* rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::computePreferredLogicalWidths):
* rendering/RenderTableCell.h:
* rendering/RenderTableCol.cpp:
(WebCore::RenderTableCol::computePreferredLogicalWidths):
* rendering/RenderTableCol.h:
* rendering/RenderText.cpp:
(WebCore::RenderText::trimmedPrefWidths):
(WebCore::RenderText::minPreferredLogicalWidth):
(WebCore::RenderText::maxPreferredLogicalWidth):
(WebCore::RenderText::computePreferredLogicalWidths):
(WebCore::RenderText::width):
* rendering/RenderText.h:
* rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::computePreferredLogicalWidths):
* rendering/RenderTextControl.h:
* rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::preferredContentWidth):
(WebCore::RenderTextControlSingleLine::preferredDecorationWidthRight):
* rendering/RenderVideo.cpp:
(WebCore::RenderVideo::updateIntrinsicSize):
* rendering/RenderView.cpp:
(WebCore::RenderView::RenderView):
(WebCore::RenderView::computePreferredLogicalWidths):
(WebCore::RenderView::layout):
* rendering/RenderView.h:
* rendering/TableLayout.h:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68276 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2010-09-24  Tony Chang  <tony@chromium.org>

        Unreviewed, updating test_expectations.txt.

        Removing tests that are now passing in test_shell.

        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68277 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2010-09-24  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Simon Fraser.

        Comply with spec by generalizing container on which transforms can be applied.
        https://bugs.webkit.org/show_bug.cgi?id=46485

        Already covered by existing tests.

        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::getTransformFromContainer):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68278 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2010-09-24  Tony Chang  <tony@chromium.org>

        Unreviewed, fix chromium compile after r68276 which renamed
        Render*::minPrefWidth to minPreferredLogicalWidth.

        * src/WebFrameImpl.cpp:
        (WebKit::WebFrameImpl::contentsPreferredWidth):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68279 268f45cc-cd09-0410-ab3c-d52691b4dbfc
automaticSpellingCorrectionEnabled isn't updated.
https://bugs.webkit.org/show_bug.cgi?id=46486
<rdar://problem/8475212>

Patch by Jia Pu <jpu@apple.com> on 2010-09-24
Reviewed by Dan Bernstein.

* WebView/WebView.mm:
(+[WebView initialize]): Should update "automaticSpellingCorrectionEnabled"
  instead of "automaticTextReplacementEnabled".



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68280 268f45cc-cd09-0410-ab3c-d52691b4dbfc
REGRESSION(r68223): It broke 2-3 tests on bots (Requested by Ossy on #webkit).
https://bugs.webkit.org/show_bug.cgi?id=46448

Reviewed by Gavin Barraclough

Roll this back in, with additional logic to prevent us from delaying construction
of functions named "arguments"

* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dump):
* bytecode/Opcode.h:
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::emitInitLazyRegister):
(JSC::BytecodeGenerator::registerFor):
(JSC::BytecodeGenerator::createLazyRegisterIfNecessary):
(JSC::BytecodeGenerator::constRegisterFor):
(JSC::BytecodeGenerator::emitNewFunction):
(JSC::BytecodeGenerator::emitLazyNewFunction):
(JSC::BytecodeGenerator::emitNewFunctionInternal):
* bytecompiler/BytecodeGenerator.h:
* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
* jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass):
* jit/JIT.h:
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_init_lazy_reg):
(JSC::JIT::emit_op_new_func):
* jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_init_lazy_reg):
* parser/Nodes.h:
(JSC::ScopeNode::needsActivationForMoreThanVariables):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68281 268f45cc-cd09-0410-ab3c-d52691b4dbfc
https://bugs.webkit.org/show_bug.cgi?id=46489, rename the lineWidth and left/RightOffset methods
to reflect that they will be logical.

Reviewed by Sam Weinig.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::determineHorizontalPosition):
(WebCore::RenderBlock::leftSelectionOffset):
(WebCore::RenderBlock::rightSelectionOffset):
(WebCore::RenderBlock::positionNewFloats):
(WebCore::RenderBlock::logicalLeftOffsetForContent):
(WebCore::RenderBlock::logicalLeftOffsetForLine):
(WebCore::RenderBlock::logicalRightOffsetForContent):
(WebCore::RenderBlock::logicalRightOffsetForLine):
(WebCore::RenderBlock::availableLogicalWidthForLine):
(WebCore::RenderBlock::getClearDelta):
* rendering/RenderBlock.h:
(WebCore::RenderBlock::logicalRightOffsetForLine):
(WebCore::RenderBlock::logicalLeftOffsetForLine):
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::computeInlineDirectionPositionsForLine):
(WebCore::RenderBlock::layoutInlineChildren):
(WebCore::RenderBlock::skipTrailingWhitespace):
(WebCore::RenderBlock::skipLeadingWhitespace):
(WebCore::RenderBlock::fitBelowFloats):
(WebCore::RenderBlock::findNextLineBreak):
(WebCore::RenderBlock::checkLinesForTextOverflow):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::containingBlockWidthForContent):
* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::applyLineClamp):
* rendering/RenderListItem.cpp:
(WebCore::RenderListItem::positionListMarker):
* rendering/RenderTable.cpp:
(WebCore::RenderTable::computeLogicalWidth):
* rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::selectionTop):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68282 268f45cc-cd09-0410-ab3c-d52691b4dbfc