builder: internals: fix incomplete chown walk when fixing permissions

This patch fixes the permission fixing code used by addContext, which
would not be responsible for Lchown-ing top-level directories added to a
destination that didn't exist prior to untar-ing the context.

Signed-off-by: Aleksa Sarai <cyphar@cyphar.com> (github: cyphar)
Simplify FollowSymlinkInScope based on Go 1.3.3's EvalSymlinks

Signed-off-by: Andrew Page <admwiggin@gmail.com>
Refactor of symlink tests to remove testdata dir

Signed-off-by: Tibor Vass <teabee89@gmail.com>
symlink: cleanup names and break big test into multiple smaller ones

Signed-off-by: Tibor Vass <teabee89@gmail.com>
symlink: add more tests

Signed-off-by: Tibor Vass <teabee89@gmail.com>
Add another symlink breakout test

Signed-off-by: Tibor Vass <teabee89@gmail.com>

Conflicts:
	integration-cli/docker_cli_build_test.go
integ-cli: add build test for absolute symlink

Signed-off-by: Cristian Staretu <cristian.staretu@gmail.com>
integ-cli: add test for links in volumes

Signed-off-by: Cristian Staretu <cristian.staretu@gmail.com>
Add build tests covering extraction in chroot

Signed-off-by: Cristian Staretu <cristian.staretu@gmail.com>
Update chroot apply layer to handle decompression outside chroot

Signed-off-by: Michael Crosby <crosbymichael@gmail.com>

Conflicts:
	pkg/archive/diff.go
	pkg/chrootarchive/archive.go

Conflicts:
	pkg/archive/diff.go
	pkg/chrootarchive/diff.go
Decompress archive before streaming the unpack in a chroot

Signed-off-by: Michael Crosby <crosbymichael@gmail.com>

Conflicts:
	pkg/archive/archive.go
	pkg/chrootarchive/archive.go

Conflicts:
	pkg/archive/archive.go
Add integration test for xz path issue

Signed-off-by: Arnaud Porterie <arnaud.porterie@docker.com>

Conflicts:
	integration-cli/docker_cli_build_test.go
validate image ID properly & before load

Signed-off-by: Cristian Staretu <cristian.staretu@gmail.com>

Conflicts:
	graph/load.go
docs: Add release notes

Signed-off-by: Tibor Vass <teabee89@gmail.com>
Bump version to v1.3.3

Conflicts:
	VERSION

Signed-off-by: Cristian Staretu <cristian.staretu@gmail.com>
Signed-off-by: Tibor Vass <teabee89@gmail.com>
Change version to 1.3.3-dev

Signed-off-by: Tibor Vass <teabee89@gmail.com>
Merge pull request #9620 from tiborvass/merge_release_v1.3.3

Merge release v1.3.3
Merge pull request #9616 from cyphar/9608-builder-fix-incomplete-chown-walk-addcontext

builder: internals: fix incomplete chown walk when fixing permissions
Deprecating ResolveRepositoryName

Passing RepositoryInfo to ResolveAuthConfig, pullRepository, and pushRepository

Moving --registry-mirror configuration to registry config

Created resolve_repository job

Repo names with 'index.docker.io' or 'docker.io' are now synonymous with omitting an index name.

Adding test for RepositoryInfo

Adding tests for opts.StringSetOpts and registry.ValidateMirror

Signed-off-by: Don Kjer <don.kjer@gmail.com>

gofmt changes

Signed-off-by: Don Kjer <don.kjer@gmail.com>

Fixing search term use of repoInfo

Signed-off-by: Don Kjer <don.kjer@gmail.com>

Adding integration tests for registry mirror configuration

Signed-off-by: Don Kjer <don.kjer@gmail.com>

Normalizing LookupImage image name to match LocalName parsing rules

Signed-off-by: Don Kjer <don.kjer@gmail.com>

Normalizing repository LocalName to avoid multiple references to an official image

Signed-off-by: Don Kjer <don.kjer@gmail.com>

Fixing merge issue

Signed-off-by: Don Kjer <don.kjer@gmail.com>

Removing errorOut use in tests

Signed-off-by: Don Kjer <don.kjer@gmail.com>

Removing TODO comment

Signed-off-by: Don Kjer <don.kjer@gmail.com>

Removing unused StringSetOpts

Signed-off-by: Don Kjer <don.kjer@gmail.com>

gofmt changes

Signed-off-by: Don Kjer <don.kjer@gmail.com>

golint comments cleanup.  renaming RegistryOptions => registry.Options, and RegistryServiceConfig => registry.ServiceConfig

Signed-off-by: Don Kjer <don.kjer@gmail.com>

Splitting out builtins.Registry and registry.NewService calls

Signed-off-by: Don Kjer <don.kjer@gmail.com>

Stray whitespace cleanup

Signed-off-by: Don Kjer <don.kjer@gmail.com>

Moving integration tests for Mirrors and InsecureRegistries into TestNewIndexInfo unit test

Signed-off-by: Don Kjer <don.kjer@gmail.com>

gofmt changes.  removing unused logging line

Signed-off-by: Don Kjer <don.kjer@gmail.com>

Factoring out ValidateRepositoryName from NewRepositoryInfo

Signed-off-by: Don Kjer <don.kjer@gmail.com>

Fixing broken integration tests

Signed-off-by: Don Kjer <don.kjer@gmail.com>

Fixing broken unit test after rebase

Signed-off-by: Don Kjer <don.kjer@gmail.com>

Merging IsSecure changes

Signed-off-by: Don Kjer <don.kjer@gmail.com>

More --insecure merge integration

Signed-off-by: Don Kjer <don.kjer@gmail.com>

Removing unused IndexServerURL

Signed-off-by: Don Kjer <don.kjer@gmail.com>
Allowing json marshaling of ServiceConfig.  Exposing ServiceConfig in /info

Signed-off-by: Don Kjer <don.kjer@gmail.com>