-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

This is signing heartbeats for heartbeatList, not for the sake of
authentication of the actual heartbeat. That hasn't been handled yet
and should be inside the update & handled by ProduceHeartbeat.

On 03/10/2014 11:18 PM, DavidVorick wrote:
> In src/swarm/stateinformed.go:
> 
>> }
>> 
>> -func (s *StateSwarmInformed) produceSignedHeartbeats() { - -
>> signatures := make(map[string]string) -	for id, _ := range
>> s.heartbeats { -		//Dummy signature -		signatures[id] = id -	} - 
>> -	h := NewHeartbeatList(s.chain.Id, s.chain.Host, s.heartbeats,
>> signatures) -	go s.sendUpdate(h) +func (s *StateSwarmInformed)
>> SignHeartbeat(h *Heartbeat) string { +	return h.Id
> 
> should this function return anything?
> 
> I almost feel like the signature for the heartbeat should be the
> last variable in the heartbeat. You'd sign the rest of the stuff
> then add the signature at the bottom.
> 
> Though it may be cleaner to implement signing if we instead add
> the signature to the update part. Actually, we should do it that
> way because then we enforce that every update has a signature?
> Thoughts? Might there be updates that don't need signatures? I
> currently can't think of one.
> 
> — Reply to this email directly or view it on GitHub 
> <https://github.com/Siacoin/Sia/pull/39/files#r10460528>.
> 

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBAgAGBQJTHoFYAAoJEHP1nN3uZoHu+LUIAOzLsQyRvsN+dRN5ErtfjkaR
0GvxIDx028Hy8YM05QxC3JsHYB7Pm7socEFjvs3OnAPAjePkyhSJ6/71APbohVl+
iiz/tf3+81QdIPwpJQeZLGwYiEwBnHJDRXaQgQIJloKExAOQCg7Xasqz5xdU9wBp
ruvULOeN5AZ2HEpKxY/lsmEg2ApJoo34S5IoGOoX9pSpzXgzUM2q4v/vewPKJIEd
fEd2Lky2S8qLBY3TqmGFuQvY40A3ZtctixH+xN6F/PvCsEaAblFR/IEag+d0F7me
2h+KeYE8J9IGeOTiVIEE1jqcnIzw432gRXrhdXFd3ASt9iihI6KafJcd5QgKhDg=
=JVfN
-----END PGP SIGNATURE-----