done.


On Tue, May 6, 2014 at 11:46 AM, abergeron <notifications@github.com> wrote:

> In theano/compile/ops.py:
>
> > @@ -611,3 +614,142 @@ def c_code_cache_version(self):
> >              version.append((str(t), v))
> >
> >          return tuple(version)
> > +
> > +
> > +def register_specify_shape_c_code(typ, code, version=(),
> > +                                  c_support_code_apply=None):
> > +    """ Tell SpecifyShape how to generate C code for a Theano Type
> > +
> > +    :param typ: A Theano type. It must be the Theano class itself and not an
> > +                instance of the class.
> > +    :param code: C code that check the shape and return a view for the Theano type 'typ'.
> > +                 Use %(iname)s and %(oname)s for the input and output C
> > +                 variable names respectively.
> > +                 %(axis)s for the axis that we need to check in a loop on iname.ndim.
>
> This is still wrong. %(axis)s is never supplied in the c_code below so it
> can't be used. It also does not mention %(shape)s which is the shape we
> should be checking.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/Theano/Theano/pull/1839/files#r12331498>
> .
>