FACES-1993 prepend ids of PartialVisitContext(s) with portlet namespace

On Wed, Oct 29, 2014 at 3:17 PM, Kyle Stiemann <notifications@github.com>
wrote:

> Could line 35 and 36 be simplified to if (!id.startsWith(separator) &&
> !id.startsWith(containerClientIdAndSeparator) {?
>
I don't think this simplifies anything, but this change is in the pull
already.

> Also I'm wondering if the containerClientId should be prepended even when
> the id begins with seperatorChar. Would that make sense? I know that
> technically if you prepend with a seperatorChar you are looking to start
> at the root. But in a portlet, isn't the root the containerClientId?
>
I wonder the same thing.

findComponent
<http://docs.oracle.com/cd/E17802_01/j2ee/javaee/javaserverfaces/1.2_MR1/docs/api/javax/faces/component/UIComponent.html#findComponent(java.lang.String)>
expects and checks for a leading separatorChar for better or for worse.
I am concerned about subsequent calls to findComponent using these ids,
which may no longer work because, with the change you are suggesting, there
would "never" be a leading separatorChar.

Find a test case where this logic is broken, and you will have won me over
immediately.