do you need to check that url and secret are not empty strings?