+1

Arun Ahuja <notifications@github.com> wrote:

>> +    prefix.drop(1) + suffix
>> +  }
>> +
>> +  override def toString: String = {
>> +    prefix + "[" + suffix + "]"
>> +  }
>> +}
>> +
>> +/**
>> + * class representing a path made of kmers.
>> + *
>> + * @param edges Edges of kmer graph.
>> + */
>> +class KmerPath(val edges: Seq[Kmer]) extends Ordered[KmerPath] {
>> +
>> +  val weight: Int = edges.map(_.multiplicity).fold(0)(_ + _)
>
>Yes, I agree. I had mentioned this on PR#28 and it was mentioned that a no edge path could be a valid case, but I think it's better to not have that as an option
>
>---
>Reply to this email directly or view it on GitHub:
>https://github.com/bigdatagenomics/avocado/pull/46/files#r11774872<p>In avocado-core/src/main/scala/org/bdgenomics/avocado/algorithms/debrujin/Kmer.scala:</p>
><pre style='color:#555'>&gt; +    prefix.drop(1) + suffix
>&gt; +  }
>&gt; +
>&gt; +  override def toString: String = {
>&gt; +    prefix + &quot;[&quot; + suffix + &quot;]&quot;
>&gt; +  }
>&gt; +}
>&gt; +
>&gt; +/**
>&gt; + * class representing a path made of kmers.
>&gt; + *
>&gt; + * @param edges Edges of kmer graph.
>&gt; + */
>&gt; +class KmerPath(val edges: Seq[Kmer]) extends Ordered[KmerPath] {
>&gt; +
>&gt; +  val weight: Int = edges.map(_.multiplicity).fold(0)(_ + _)
></pre>
><p>Yes, I agree. I had mentioned this on PR#28 and it was mentioned that a no edge path could be a valid case, but I think it's better to not have that as an option</p>
>
><p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br>Reply to this email directly or <a href='https://github.com/bigdatagenomics/avocado/pull/46/files#r11774872'>view it on GitHub</a>.<img src='https://github.com/notifications/beacon/3752466__eyJzY29wZSI6Ik5ld3NpZXM6QmVhY29uIiwiZXhwaXJlcyI6MTcxMzQ1MzQ1MywiZGF0YSI6eyJpZCI6MzAxMTcxNDh9fQ==--cac2a75cbb11c7e408548f7bc71a4ed7a0b1010a.gif' height='1' width='1'></p>