On 12/05/14 10:50, Nicolas Charles wrote:
>
> In tree/30_generic_methods/file_ensure_lines_in_section_present.cf:
>
> > @@ -21,14 +21,14 @@
> >  #
> >  # @parameter file File name to edit
> >  # @parameter section Section where the lines should be added
>
> ok for the first comment, however, for the naming, I'd rather follow 
> the general convention which is going from less specific to most 
> specific, so file_ensure_lines_in_ini_section_present (so that we can 
> have in the future file_ensure_lines_in_ini_section_absent)
>
>

Actually, that is exactly the reasoning I used to choose that name: I 
think it is more specific to be choosing the place in the file you want 
to add lines than knowing that you want to add a line.

And if you look at other bundle names, it will be easier to find this 
one in this list:

     file_ensure_lines_absent
     file_ensure_lines_absent_in_ini_section
     file_ensure_lines_present
     file_ensure_lines_present_in_ini_section
     file_ensure_lines_present_after_regex
     file_ensure_lines_present_before_regex
     file_ensure_lines_present_between_regex

Do you agree?